From owner-freebsd-fs@FreeBSD.ORG  Thu Feb 19 18:19:49 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 374BE106564A
	for <freebsd-fs@freebsd.org>; Thu, 19 Feb 2009 18:19:49 +0000 (UTC)
	(envelope-from hartzell@alerce.com)
Received: from merlin.alerce.com (merlin.alerce.com [64.62.142.94])
	by mx1.freebsd.org (Postfix) with ESMTP id 22FBF8FC20
	for <freebsd-fs@freebsd.org>; Thu, 19 Feb 2009 18:19:49 +0000 (UTC)
	(envelope-from hartzell@alerce.com)
Received: from merlin.alerce.com (localhost [127.0.0.1])
	by merlin.alerce.com (Postfix) with ESMTP id 541BA33C62;
	Thu, 19 Feb 2009 10:02:41 -0800 (PST)
Received: from merlin.alerce.com (localhost [127.0.0.1])
	by merlin.alerce.com (Postfix) with ESMTP id CA20D33C5B;
	Thu, 19 Feb 2009 10:02:40 -0800 (PST)
From: George Hartzell <hartzell@alerce.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18845.40641.33220.936902@almost.alerce.com>
Date: Thu, 19 Feb 2009 10:02:41 -0800
To: freebsd-current@freebsd.org,
    freebsd-fs@freebsd.org
X-Mailer: VM 8.0.12 under 22.1.50.1 (i386-apple-darwin8.11.1)
X-Virus-Scanned: ClamAV using ClamSMTP
Cc: goran.lowkrantz@ismobile.com, Pawel Jakub Dawidek <pjd@freebsd.org>
Subject: Patch for 'zfs send -R' core dump (pr bin/130105)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: hartzell@alerce.com
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2009 18:19:49 -0000


The following patch to

  /usr/src/sys/cddl/contrib/opensolaris/common/zfs/zfs_prop.c

seems to keep 'zfs send -R' from dumping core.  I've only been able to
test sending the stream to /dev/null or a file, I'm still setting up a
pool to do the receiving.

This is based on a bit of gdb debugging and a thread from zfs-fuse:

   http://groups.google.com/group/zfs-fuse/browse_thread/thread/158cb78bc3325ae3/6a0109c7b0942707?#6a0109c7b0942707

g.

--- zfs_prop.c	2009/02/17 18:58:58	1.1
+++ zfs_prop.c	2009/02/19 09:54:04
@@ -297,7 +297,7 @@
 
 	/* hidden properties */
 	register_hidden(ZFS_PROP_CREATETXG, "createtxg", PROP_TYPE_NUMBER,
-	    PROP_READONLY, ZFS_TYPE_DATASET, NULL);
+	    PROP_READONLY, ZFS_TYPE_DATASET, "CREATETXG");
 	register_hidden(ZFS_PROP_NUMCLONES, "numclones", PROP_TYPE_NUMBER,
 	    PROP_READONLY, ZFS_TYPE_SNAPSHOT, NULL);
 	register_hidden(ZFS_PROP_NAME, "name", PROP_TYPE_STRING,