From owner-freebsd-arm@FreeBSD.ORG  Sat Feb 14 20:57:42 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0BF1D5C1
 for <freebsd-arm@freebsd.org>; Sat, 14 Feb 2015 20:57:42 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DE15E650
 for <freebsd-arm@freebsd.org>; Sat, 14 Feb 2015 20:57:41 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1EKvfcB061411
 for <freebsd-arm@freebsd.org>; Sat, 14 Feb 2015 20:57:41 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1EKvfTU061410;
 Sat, 14 Feb 2015 20:57:41 GMT (envelope-from root)
Date: Sat, 14 Feb 2015 20:57:41 +0000
To: freebsd-arm@freebsd.org
From: "kmacy (Kip Macy)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D1833: Add memory barriers to buf_ring
Message-ID: <9488b40e69c7ed9a70a252770a91f7c9@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1833: Add memory barriers to buf_ring
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-To: <PHID-USER-22avn2hssqzufmcg2crf>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-Cc: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-ntnotl4wj5wcj2eoukly-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-ntnotl4wj5wcj2eoukly-req@FreeBSD.org>
Thread-Index: OGRiNDkxY2NmMjRiNTc0MjQ4YTYwNWVkNzIyIFTftsU=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2015 20:57:42 -0000

kmacy added a comment.

I'm mostly echoing Ian Lepore's comments here:

- The wmb() is equivalent to an atomic_store_acq_32 - which is not part of the API. It would seem we'd rather have a atomic_load_acq_32 where the value is actually later to be read. 

- I don't know what the rmb() is protecting against.

- This penalizes architectures that don't need it so at the very least a local macro needs to be defined that is a no-op on all other architectures. 

Are you actually seeing problems that is fixed by this change?

REVISION DETAIL
  https://reviews.freebsd.org/D1833

To: zbb, imp, rpaulo, kmacy
Cc: andrew, ian, adrian, freebsd-arm