From nobody Sun Aug 9 10:08:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hHtrF1kxXz6nRyZ for ; Sun, 09 Aug 2026 10:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hHtrF02tGz3t9X for ; Sun, 09 Aug 2026 10:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786270109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QMXV2LZZKlVXDx8XkmHaYsaUrwlb8BOamS/zIs+LZBQ=; b=wqa6zz8zFJ+2mRmoLrmJf2L+IVBaGnaF6GY4LY1TMtKKv3hQxaryBHfGisgMVMI/inmp+F S+yUwehmA9WUWX6QKyu5L1eAhY2e/oguRRBJeYTnlu3pURANcjc32LK6o7hrcFG5LZOIgf xtK42wgGcfPiYG6UQ1Vt5nPfKdx5rJtoez2JO0saKqOTojH3oo865nFQT2WrqadAgfrw87 5bFESSNOnYNUjzNo+8BXB+UH8a0qSI9JQgH2budbRPzHFYC9xxxaiyStY08TU6WISO9jEs d1xGpNiwURY34kmm1sdUf0CvZk55CaIVCpcTFqdOJnrd6lZVuIbIBHDRprmjHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786270109; a=rsa-sha256; cv=none; b=eR4Oyqj2NtROFT0THQy5IetDXHMIaMyy94FlLeG1qsYaJlKY5yPEOritm1v1rufK+EXeHi pjbBJC8HbvfcfCk5zyNeEO909kaPiU/y4cgs08CAYKz96ToxiiQG6/ylizsMJ6aXmmm6jW m0iRHN/6N/R28mDxI/8XefD9+yBRyM8RWa+S4tQGRw7J8K35RDaMcWfS/8ajEigbHLg0rq Q1cyH6OEzu4kHQClAyRh29gQylMBCViWoMcj+6Pb3VME432hFjluxmPRWZPWc+60i6Vky7 xfd04/fhn5GW8jX0dJKUXd/hIVXJmyGaTQDcYSrXXyVe8tlSOzwNcNzBGNU98w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786270109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QMXV2LZZKlVXDx8XkmHaYsaUrwlb8BOamS/zIs+LZBQ=; b=JvD/ifmpo498hbIfrvnHnuvJFsg9vHVVJ62mhDFlX7syqQLleSiLVmby8BMqklPOuJR6PV DLceTv4gAJccz/EWymdG6rwe/ZQ2bPdDm+ISlR3YKqWAGGBmNlMFRPHrbPZ+2HMskqMS64 0vG6CP+b7d+zf8BBWe+opb7UfSLdB4nk6Piv3Ihum3rf93MkiG4nk5/I2VcES3qpIEULC0 8zo08iXcM/ZWMchz/ctdDe+rI6imbM3oFIUy2eRS6ZQmq2FA0WGQFKvdFntXF6oGYxd8II R/c1HSWLHyN/+r5c6IjYU8iXYM6b+xCAR1ovGFGRS86rFgjJGdKQL/87slcLcA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hHtrD4lZNz2k3 for ; Sun, 09 Aug 2026 10:08:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36326 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 09 Aug 2026 10:08:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 8696cc600f44 - main - iflib: Avoid locking for unsupported VF status queries List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8696cc600f44767e7988a92c8e6fb943e97d4cc7 Auto-Submitted: auto-generated Date: Sun, 09 Aug 2026 10:08:23 +0000 Message-Id: <6a785197.36326.2e30a61c@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8696cc600f44767e7988a92c8e6fb943e97d4cc7 commit 8696cc600f44767e7988a92c8e6fb943e97d4cc7 Author: Kevin Bowling AuthorDate: 2026-08-09 09:12:38 +0000 Commit: Kevin Bowling CommitDate: 2026-08-09 10:07:35 +0000 iflib: Avoid locking for unsupported VF status queries ifconfig -v requests SR-IOV VF status from every interface. iflib previously acquired the context lock before dispatching the request even for VFs and drivers using the default unsupported method. Mailbox work on a VF could therefore delay the complete interface listing. VF status describes the children of an SR-IOV PF. Reject requests on VF contexts and classes using the default method without taking the context lock. Keep the lock for actual PF status providers. Fixes: 1ccf543b21ef ("ifconfig: Add SR-IOV VF status output") --- sys/net/iflib.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 54001be3eae5..8322dbfb074d 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -4658,10 +4658,27 @@ iflib_if_ioctl(if_t ifp, u_long command, caddr_t data) CTX_UNLOCK(ctx); break; case SIOCGIFVFSTATUS: + { + kobjop_desc_t kobj_desc; + kobj_method_t *kobj_method; + + /* VF status describes children of an SR-IOV PF. */ + if (CTX_IS_VF(ctx)) { + err = ENOTSUP; + break; + } + kobj_desc = &ifdi_vf_status_desc; + kobj_method = kobj_lookup_method(((kobj_t)ctx)->ops->cls, + NULL, kobj_desc); + if (kobj_method == &kobj_desc->deflt) { + err = ENOTSUP; + break; + } CTX_LOCK(ctx); err = IFDI_VF_STATUS(ctx, (nvlist_t *)data); CTX_UNLOCK(ctx); break; + } default: err = ether_ioctl(ifp, command, data); break;