From owner-freebsd-ports@FreeBSD.ORG  Sat Jan  5 20:24:22 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4211A16A41B
	for <ports@freebsd.org>; Sat,  5 Jan 2008 20:24:22 +0000 (UTC)
	(envelope-from swhetzel@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.154])
	by mx1.freebsd.org (Postfix) with ESMTP id D22F713C448
	for <ports@freebsd.org>; Sat,  5 Jan 2008 20:24:21 +0000 (UTC)
	(envelope-from swhetzel@gmail.com)
Received: by fg-out-1718.google.com with SMTP id 16so4646809fgg.35
	for <ports@freebsd.org>; Sat, 05 Jan 2008 12:24:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
	bh=FtNN1HYj/9LJTXcEDyvs1AZlpTjGRX91S09OuuyUQ4o=;
	b=fnFXbqsGEpZs+gdb7DZ2P4r1Fy7hMSkP+YM7ylwOIS+TeG3HVxjOokxH7/XYhq6KqTO/xIYR7FvcM4EPESL2u6B9J/KNjr3ssKcQbM0Di9prMnHZeQNkZ7/Gv/STpmJr0ZkNUkohyOw7XTuZkHAHz8FhSka+zAn+v6XUN1ltC/8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
	b=EFP3tXITvDG57j4QQrPKLiMWrv0VgetOCaRTkcq5v4AnvM98bBmWuSeLcMjXh6EWyXJ/XLVMeJQgv0O+yNpPYbvh3iNS82GhHxeN1bX0MjlH56NG488/7mA5AroDs9JItNRSU7NCUGt+NzAXWWtDXroNygB34XjRgXIpBCZi7m0=
Received: by 10.86.65.11 with SMTP id n11mr9490974fga.4.1199564660596;
	Sat, 05 Jan 2008 12:24:20 -0800 (PST)
Received: by 10.86.3.20 with HTTP; Sat, 5 Jan 2008 12:24:20 -0800 (PST)
Message-ID: <790a9fff0801051224p4fb8481pbcc24051b2438dcf@mail.gmail.com>
Date: Sat, 5 Jan 2008 14:24:20 -0600
From: "Scot Hetzel" <swhetzel@gmail.com>
To: "Xin LI" <delphij@freebsd.org>, sergei@freebsd.org, ports@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Cc: 
Subject: sysutils/cfengine: invalid use of USE_BDB
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2008 20:24:22 -0000

I have noticed that sysutils/cfengine is using USE_BDB incorrectly.

USE_BDB?= 46

The USE_BDB variable is not a user setable variable. If someone were
to read this Makefile, they would get the wrong impression that they
should set USE_BDB in there /etc/make.conf, ports.conf, or
portupgrade.conf file.   When they should instead be setting the
WITH_BDB_VER variable.

The USE_BDB should be set to the minimum version of Berkeley DB that
the port will build with.

USE_BDB= 44+

And left up to the person installing the port to specify a higher version.

If you want to take the choice away from the installer and have the
port always use BDB 4.6, then the port should use:

USE_BDB= 46

Which will prevent the use of BDB 4.4 and 4.5 from ever being used by this port.

Scot