Date: Sun, 14 Feb 2021 11:38:24 -0600 From: Jason Bacon <bacon4000@gmail.com> To: Christoph Moench-Tegeder <cmt@burggraben.net>, "Jason W. Bacon" <jwb@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r565224 - in head/lang/pocl: . files Message-ID: <bbaa5a6a-cde9-052a-e631-7acfcf9b6937@gmail.com> In-Reply-To: <YCkoTsUm1QeWBzO8@elch.exwg.net> References: <202102141304.11ED4BTl046406@repo.freebsd.org> <YCkoTsUm1QeWBzO8@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/14/21 7:40 AM, Christoph Moench-Tegeder wrote: > ## Jason W. Bacon (jwb@FreeBSD.org): > >> New Revision: 565224 >> URL: https://svnweb.freebsd.org/changeset/ports/565224 >> >> Log: >> lang/pocl: Update hwloc dependency to hwloc2 > The intention is great, but the execution... has problems. > >> -PORTNAME=3D pocl >> +PORTNAME=3D pocl > First, while I'm all in favor of consistent white space, mixing this > with the stated (per commit message) change makes the diff harder > to read and "svn annotate" (and similar tools) harder to use later on. Are you suggesting that whitespace changes should be done in a separate=20 commit? > >> BUILD_DEPENDS=3D llvm${LLVM_VERSION}>=3D0:devel/llvm${LLVM_VERSION} = \ >> - opencl>=3D2.2:devel/opencl >> -LIB_DEPENDS=3D libhwloc.so:devel/hwloc \ >> - libOpenCL.so:devel/ocl-icd >> -RUN_DEPENDS=3D ${BUILD_DEPENDS} >> + opencl>=3D2.2:devel/opencl >> +LIB_DEPENDS=3D libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd= >> +RUN_DEPENDS=3D libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd= > And this is plain wrong. libhwloc.so.15 and libOpenCL.so are not > "executables or files this port depends on" - they're libraries and > belong into LIB_DEPENDS only. At the same time, you dropped that > llvm from RUN_DEPENDS - now that I look at it closely, I have a hunch > that the previous "RUN_DEPENDS=3D ${BUILD_DEPENDS}" wasn't right either= > (would this really need sphinx, cmake and ninja as RUN_DEPENDS?), > but none of that is even mentioned in the commit message and I > cannot tell if this was intentional or an accident. > > Anyways, the build bombs out in run-depends "pocl-1.6 depends on > executable: libhwloc.so.15 - not found", which is why I looked at this > in the first place. > Oy...=C2=A0 Not feeling well today but have to push through the pile on m= y=20 desk.=C2=A0 This was some sort of mishap copying the changes after poudri= ere=20 testing elsewhere.=C2=A0 I'll just reverse the RUN_DEPENDS change for now= =2E=C2=A0=20 This port needs more work I'm in no shape to do today. Thanks for the heads-up, =C2=A0=C2=A0=C2=A0 JB --=20 Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bbaa5a6a-cde9-052a-e631-7acfcf9b6937>