From owner-cvs-src-old@FreeBSD.ORG Wed Jan 6 16:52:11 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CDF61065770 for ; Wed, 6 Jan 2010 16:52:11 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8AF8F8FC19 for ; Wed, 6 Jan 2010 16:52:11 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o06GqBhU003522 for ; Wed, 6 Jan 2010 16:52:11 GMT (envelope-from bz@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o06GqBes003521 for cvs-src-old@freebsd.org; Wed, 6 Jan 2010 16:52:11 GMT (envelope-from bz@repoman.freebsd.org) Message-Id: <201001061652.o06GqBes003521@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to bz@repoman.freebsd.org using -f From: "Bjoern A. Zeeb" Date: Wed, 6 Jan 2010 16:51:57 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 16:52:11 -0000 bz 2010-01-06 16:51:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: SVN rev 201655 on 2010-01-06 16:51:57Z by bz MFC r184722: Fix a bug introduced with r182851 (r201653 in stable/7) splitting tcp_mss() into tcp_mss() and tcp_mss_update() so that tcp_mtudisc() could re-use the same code. Move the TSO logic back to tcp_mss() and out of tcp_mss_update(). We tried to avoid that initially but if were are called from tcp_output() with EMSGSIZE, we cleared the TSO flag on the tcpcb there, called into tcp_mtudisc() and tcp_mss_update() which then would reenable TSO on the tcpcb based on TSO capabilities of the interface as learnt in tcp_maxmtu/6(). So if TSO was enabled on the (possibly new) outgoing interface it was turned back on, which lead to an endless loop between tcp_output() and tcp_mtudisc() until we overflew the stack. Reported by: kmacy Revision Changes Path 1.370.2.17 +10 -9 src/sys/netinet/tcp_input.c 1.300.2.17 +1 -1 src/sys/netinet/tcp_subr.c 1.157.2.8 +1 -1 src/sys/netinet/tcp_var.h