From nobody Mon Oct 9 15:53:00 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S43TT21spz4wtt0 for ; Mon, 9 Oct 2023 15:53:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S43TS5MLsz3T6G for ; Mon, 9 Oct 2023 15:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696866780; a=rsa-sha256; cv=none; b=GtwXBjetnNn+O3/EO3oyL2P6sRqjBFynYPJM2CClFdheUWxmdy8fXO9jnKTzPvjtcpv4aB FgLpshx1wA0I+nkZ3l6oGvef2fpLWfs/s4Uz12eaBZc499H1dNeIvwTqPMSwYbwqAY52He 7nvI1LyqHRclK7JqsmZtOQ2xth0MQyOIs7mG0prIf42pl8Be1UPZWMiQdQdouIUfESnyFp u2FE6mDvkylvhFUjTlLmYEBoEbOu6iek/AbJp3vhFbhoLCO71XI1jr58NicF4JDp7gaVqJ o+WfNugNDVX5jy6n4JsvXwAOUXQGuyniQIerqJkxYIOs40FCsiCa+py6cN6VAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696866780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3pFjdiHSASCCLRGL3+G55EGSP1p45P3CfbHZ+WMaZYQ=; b=raGRQF6nvBDvb1CHgjR7TTKV/RD3A79Y2BhcR18EeIVSJ+8+PgC8VvQLx/T7+E42sd4X2B vrb3HD/J3vE6S3U6J+iP2ZsemURyKWsjSO1YbGZ6nBH+9hQuSlPnd7U9kLU4/rGiL1IjNE YobIBzg1AgSdms07BXCOOEAVSUFOEYlB8AuW7+VpovXXNFBB9YmVBN0ma0HXl5uXMbTPX2 EVoLE+EqjPPUvDtQuqp+dCYfP05A7OCY3ZeYv560P50ChtAK8f1+moMLfFLZCDwYGTTNId cO3VYffxZB7Xg/T8U3BylZY+6tcEQzznPp/7upZ+3u4AqZafC6m73C3lRTAuDQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S43TS4Pm4z11s1 for ; Mon, 9 Oct 2023 15:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 399Fr0vM050600 for ; Mon, 9 Oct 2023 15:53:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 399Fr0Y0050598 for ports-bugs@FreeBSD.org; Mon, 9 Oct 2023 15:53:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices Date: Mon, 09 Oct 2023 15:53:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262032 --- Comment #8 from Robert Clausecker --- (In reply to Karl Bonde Torp from comment #7) Thank you for the update. Note that the build error (not warning) was on armv7, not arm64 (but I see = that you disabled this platform). It also happens on i386. I recommend you che= ck your code, I suspect you are using types with platform-specific length ther= e. If you disable platforms, use NOT_FOR_ARCHS if there is a fundamental reason why it won't work (e.g. lack of platform-specific code) and then define NOT_FOR_ARCHS_REASON. If the reason is just some sort of bug or build erro= r, set BROKEN_... instead. E.g. set BROKEN_armv7=3D sizeof(struct xnvme_cmd_ctx) !=3D 128 This informs other people working on the ports tree that it may be worth investigating the problem. Perhaps someone then comes along and fixes it f= or you. > Perhaps we should change this to always install them here `${PREFIX}/shar= e/bash-completion/completions` on FreeBSD. Yes, this would be correct for ports, however, it might not be correct for other users who want to install your software directly from source. Perhaps add an option to install the shell completion files and have that option default to whether bash is installed or not, but make it overridable. > Do we need completions for Fish and ZSH as well? It's not a requirement, but you are of course free to do so. > Finally, I have added options for the Tools, tests, examples etc., howeve= r this makes the pkg-plist inaccurate, since it only reflects the default. Is this okay, or is there something I need to do to fix this? The pkg-plist must be accurate for whatever options are set. Check =C2=A7 = 5.14.3.1 Porter's Handbook for the OPTIONS_SUB mechanism designed to address this requirement. That said, note that options are a build-time thing. Most users download p= orts using binary package and won't use them. Hence my request if it was appropriate to split the libraries into a separate port, so they can be installed separately (and e.g. other ports can just depend on the libraries without also installing the tools). However, this is only needed if you ex= pect 3rd party software to use the libraries. If you do not expect that, just having options is good enough. Note also that man pages should always be installed if the corresponding to= ols are installed (but please do not install man pages for tools that are not installed). I was requested a DOCS option for additional documentation, su= ch as the one shipped in the docs directory of your project (apparently it's available on line at https://xnvme.io/docs/latest/). I also saw that you added a DEBUG option. While this option can be provide= d, it's usually meant for additional debug features. Just selecting a build t= ype is done through WITH_DEBUG, and in fact, USES=3Dmeson does so automatically= . No need to put an extra option in (see Mk/Uses/meson.mk). --=20 You are receiving this mail because: You are the assignee for the bug.=