From owner-freebsd-python@FreeBSD.ORG  Fri Aug 13 14:00:18 2010
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: freebsd-python@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 626581065694
	for <freebsd-python@hub.freebsd.org>;
	Fri, 13 Aug 2010 14:00:18 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 50B568FC16
	for <freebsd-python@hub.freebsd.org>;
	Fri, 13 Aug 2010 14:00:18 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7DE0IaI033803
	for <freebsd-python@freefall.freebsd.org>; Fri, 13 Aug 2010 14:00:18 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7DE0I7A033802;
	Fri, 13 Aug 2010 14:00:18 GMT (envelope-from gnats)
Date: Fri, 13 Aug 2010 14:00:18 GMT
Message-Id: <201008131400.o7DE0I7A033802@freefall.freebsd.org>
To: freebsd-python@FreeBSD.org
From: "b. f." <bf1783@googlemail.com>
Cc: 
Subject: Re: ports/136917: [patch] lang/python26: gettext detection
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "b. f." <bf1783@googlemail.com>
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Aug 2010 14:00:18 -0000

The following reply was made to PR ports/136917; it has been noted by GNATS.

From: "b. f." <bf1783@googlemail.com>
To: bug-followup@FreeBSD.org
Cc: Anonymous <swell.k@gmail.com>
Subject: Re: ports/136917: [patch] lang/python26: gettext detection
Date: Fri, 13 Aug 2010 13:56:45 +0000

 > +.if defined(CPPFLAGS)
 > +CONFIGURE_ENV+=               CPPFLAGS="${CPPFLAGS}"
 > +.endif
 > +.if defined(LDFLAGS)
 > +CONFIGURE_ENV+=               LDFLAGS="${LDFLAGS}"
 > +.endif
 
 You need to perform these tests after all additions to CPPFLAGS and
 LDFLAGS via OPTIONS, or add both of them unconditionally to the
 CONFIGURE_ENV= ... line before the inclusion of bsd.port.pre.mk.  The
 latter is the usual approach.  The way you have it now, if there
 aren't user-defined CPPFLAGS or some other intervention, CPPFLAGS
 won't be added to CONFIGURE_ENV, even if WITH_THREADS and
 WITH_PTH=true, because CPPFLAGS won't have been defined when the test
 is performed.  Anyway, LDFLAGS is almost always defined, though it may
 be empty, via /usr/share/mk/sys.mk.  And note that, although I don't
 think it matters for this port, prepending a value to these flags (as
 in the current port Makefile) may not have the same effect as
 appending a value with += (as in your patched version) because, in
 general, search order matters.
 
 b.