From owner-freebsd-virtualization@freebsd.org Sat Nov 7 14:07:38 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E844C460F81 for ; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CSzbt63ZKz4rYW for ; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id CE22D2EFFF9; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CDE84460DB5 for ; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSzbt55pwz4rQs for ; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9D8647752 for ; Sat, 7 Nov 2020 14:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0A7E7cxq071422 for ; Sat, 7 Nov 2020 14:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0A7E7cOK071421 for virtualization@FreeBSD.org; Sat, 7 Nov 2020 14:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 250924] Bhyve AHCI disk controller regression due to r364334 Date: Sat, 07 Nov 2020 14:07:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: freebsd@gulag.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2020 14:07:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250924 Bug ID: 250924 Summary: Bhyve AHCI disk controller regression due to r364334 Product: Base System Version: 12.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: bhyve Assignee: virtualization@FreeBSD.org Reporter: freebsd@gulag.ch Created attachment 219426 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D219426&action= =3Dedit diff patch against r364334 Since https://svnweb.freebsd.org/base?view=3Drevision&revision=3D364334 Sol= aris and Illumos guests are no longer able to detect the Bhyve AHCI disk controller = and the following error is reported: --- SATA disk device at port X does not support UDMA --- https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/io/s= ata/impl/sata.c#L12752 The culprit seems to be the missing ATA flag 88 at offset 53 in the paramet= er buffer and this flag is indeed no longer set in 12.2-p0: RELEASE-12.1: buf[53] =3D (1 << 1 | 1 << 2); RELEASE-12.2: ata_ident->atavalid =3D (ATA_FLAG_54_58 | ATA_FLAG_64_70) sys/sys/ata.h: #define ATA_FLAG_54_58 0x0001 /* words 54-58 valid */ #define ATA_FLAG_64_70 0x0002 /* words 64-70 valid */ #define ATA_FLAG_88 0x0004 /* word 88 valid */ --- Setting the old parameters solves the problem (at least for Solaris/Illumos= ): ata_ident->atavalid =3D (ATA_FLAG_64_70 | ATA_FLAG_88) The attached patch reverts these parameters and thus restores the old behav= iour for both controllers (disk and cdrom). The question is whether this change is intentional or simply a bug. --=20 You are receiving this mail because: You are the assignee for the bug.=