From owner-svn-src-all@freebsd.org Tue Dec 12 12:49:56 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B42DE977E3 for ; Tue, 12 Dec 2017 12:49:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 16CBE7ACBD for ; Tue, 12 Dec 2017 12:49:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22e.google.com with SMTP id d137so23979784itc.2 for ; Tue, 12 Dec 2017 04:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XYcNAiUH7Y3VVmE6SNDCG15pmEIj8K8zzut7Op334EI=; b=YBPmHQVkWPJYK/lD4SWYpVn1qWLUihqHr8axS9TTpaSy9LTaZGaZgeKSNJ1sBlvYK1 5Evz2GhalWyTUa4r3rCPxl3ZoSBwN4WsyDgcNehg1Jy+G9HG0kooevd+1IaJquG384be 0ZiAb4zI7UP6a03ICIoV8zzE5A8VYGtdFakXm+qn4JJFZl/2GCcE08Mg1DdLSumA5mu5 xjiTO4EeL5eKj3AG4QZY9VMV25sa7XpVw67B8RQ7zHuTuzIPozHLgXS3A726fynkmlWt wDBxFVdzLBbDwH8lO6ewU3c0Op+Veet4i1jINUN6l9PVd0zyTZIj31Re8wiNW4uRA2So VRJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XYcNAiUH7Y3VVmE6SNDCG15pmEIj8K8zzut7Op334EI=; b=pmocW/0HuiKMAvphqutlSb6gTFFp+fglqTf4vsE9qDu1geLKLVOGvhlpaQrjaZkc1X 52amc/8V5R3diCdtjVHwKN8GxQG4PctqaYGTYt8/A95do58ZYKxeMfGQ0Hm4Ij7ddSCh fng1zfc624i04pTlc4MQjnmzch9NEd3ALK+P7z6yPimsps9XeCpH/+l/FSsNKATCdlMR LPxcNRu6PnXM/HVf3X4oCGqDkpLyZ95txqU8m8HfVccPpNBipgRlCmxNfRwdjKd5aZkO CjuRD6AZLl/qv+m2hg3FvBF31g1x+hf5uAo2I6y9rjNbcHsXyIlZABiufIQv2LM1wwYU RSEw== X-Gm-Message-State: AKGB3mKjlhtTM3bHDFYXz/4/FgM8c4f140I7a3WyZq5cERxnpuKzGIqT 0EAgrpiFEENr9N5HCMLt4uzMvAt5fn9npihC/rczTg== X-Google-Smtp-Source: ACJfBovLNw8juGInq5lbXc7zLTB/7RVkOwQEh2rUMWbXDLDBnLDL4saXnEbKhZTdu4Kbce78jLNwaUujAndh3lR7Dwk= X-Received: by 10.107.104.18 with SMTP id d18mr4596299ioc.136.1513082995142; Tue, 12 Dec 2017 04:49:55 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 12 Dec 2017 04:49:53 -0800 (PST) X-Originating-IP: [2607:fb90:9ca1:4178:151:5958:8f12:5584] Received: by 10.79.108.204 with HTTP; Tue, 12 Dec 2017 04:49:53 -0800 (PST) In-Reply-To: <201712120946.vBC9krNL075725@repo.freebsd.org> References: <201712120946.vBC9krNL075725@repo.freebsd.org> From: Warner Losh Date: Tue, 12 Dec 2017 05:49:53 -0700 X-Google-Sender-Auth: lZ2T9M-NiVBWU66iij6shL-s8Cg Message-ID: Subject: Re: svn commit: r326792 - head/stand/uboot/common To: Antoine Brodin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 12:49:56 -0000 This commit message sucks. Please use a more descriptive one in the future like "catch up to change rXXXXX that remove the argument from interact." If you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. Your message is utterly useless. It doesn't even say what arch is broken. Warner Warner On Dec 12, 2017 1:47 AM, "Antoine Brodin" wrote: > Author: antoine > Date: Tue Dec 12 09:46:53 2017 > New Revision: 326792 > URL: https://svnweb.freebsd.org/changeset/base/326792 > > Log: > Attempt to unbreak buildworld > > Modified: > head/stand/uboot/common/main.c > > Modified: head/stand/uboot/common/main.c > ============================================================ > ================== > --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 > (r326791) > +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 > (r326792) > @@ -500,7 +500,7 @@ main(int argc, char **argv) > archsw.arch_readin = uboot_readin; > archsw.arch_autoload = uboot_autoload; > > - interact(NULL); /* doesn't return */ > + interact(); /* doesn't return */ > > return (0); > } > >