From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 12 19:00:19 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E110106567A for ; Sun, 12 Dec 2010 19:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5B6648FC22 for ; Sun, 12 Dec 2010 19:00:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBCJ0JmQ056677 for ; Sun, 12 Dec 2010 19:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBCJ0J0A056676; Sun, 12 Dec 2010 19:00:19 GMT (envelope-from gnats) Resent-Date: Sun, 12 Dec 2010 19:00:19 GMT Resent-Message-Id: <201012121900.oBCJ0J0A056676@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, David Demelier Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3143B1065673 for ; Sun, 12 Dec 2010 18:52:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 207A48FC12 for ; Sun, 12 Dec 2010 18:52:33 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oBCIqWDA069391 for ; Sun, 12 Dec 2010 18:52:32 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oBCIqWSj069390; Sun, 12 Dec 2010 18:52:32 GMT (envelope-from nobody) Message-Id: <201012121852.oBCIqWSj069390@red.freebsd.org> Date: Sun, 12 Dec 2010 18:52:32 GMT From: David Demelier To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/153052: watch(8) breaks tty on error X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2010 19:00:19 -0000 >Number: 153052 >Category: misc >Synopsis: watch(8) breaks tty on error >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Dec 12 19:00:19 UTC 2010 >Closed-Date: >Last-Modified: >Originator: David Demelier >Release: 8.2-PRERELEASE >Organization: >Environment: FreeBSD Melon.malikania.fr 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #7: Wed Dec 8 14:03:55 CET 2010 root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon amd64 >Description: When you run watch and snp module is not loaded (or probably any other error) watch breaks the terminal I have removed unset_tty() and seems to work in my case, but I can't test for the others fatal() calls. markand@Melon /usr/src/usr.sbin/watch $ watch watch: snp module not available: Operation not permitted watch: fatal: cannot open snoop device % markand@Melon /usr/src/usr.sbin/watch $ ls Makefile watch.8 watch.c watch.c.orig % markand@Melon /usr/src/usr.sbin/watch $ ls -l total 26 -rw-r--r-- 1 root wheel 187 3 Aug 2009 Makefile -rw-r--r-- 1 root wheel 2645 3 Aug 2009 watch.8 -rw-r--r-- 1 root wheel 9042 12 Dec 19:46 watch.c -rw-r--r-- 1 root wheel 9042 12 Dec 19:38 watch.c.orig % >How-To-Repeat: >Fix: -- watch.c.diff begins here -- --- watch.c.orig 2010-12-12 19:38:27.000000000 +0100 +++ watch.c 2010-12-12 19:44:21.000000000 +0100 @@ -142,7 +142,6 @@ static void fatal(int error, const char *buf) { - unset_tty(); if (buf) errx(error, "fatal: %s", buf); else -- watch.d.diff ends here -- >Release-Note: >Audit-Trail: >Unformatted: