From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 9 06:40:13 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C979A1065670 for ; Mon, 9 Jan 2012 06:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A222B8FC15 for ; Mon, 9 Jan 2012 06:40:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q096eDe3061594 for ; Mon, 9 Jan 2012 06:40:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q096eDGv061593; Mon, 9 Jan 2012 06:40:13 GMT (envelope-from gnats) Resent-Date: Mon, 9 Jan 2012 06:40:13 GMT Resent-Message-Id: <201201090640.q096eDGv061593@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A6B2106564A for ; Mon, 9 Jan 2012 06:38:57 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id F355F8FC13 for ; Mon, 9 Jan 2012 06:38:56 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q096cuG6073935 for ; Mon, 9 Jan 2012 06:38:56 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q096cuMk073934; Mon, 9 Jan 2012 06:38:56 GMT (envelope-from nobody) Message-Id: <201201090638.q096cuMk073934@red.freebsd.org> Date: Mon, 9 Jan 2012 06:38:56 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163942: [patch] fix i386 build of dns/inadyn X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 06:40:13 -0000 >Number: 163942 >Category: ports >Synopsis: [patch] fix i386 build of dns/inadyn >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 09 06:40:13 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9.0-RELEASE >Organization: iXsystems, Inc. >Environment: FreeBSD bayonetta.local 9.0-STABLE FreeBSD 9.0-STABLE #1 r229323M: Mon Jan 2 14:32:54 PST 2012 gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA amd64 >Description: Building FreeNAS, we at iXsystems and the users that use FreeNAS have run into situations on more than one occasion where the inadyn binary has been corrupted somehow when building the i386 package (oddly enough the amd64 package isn't affected). The following patch ignores the contributed Makefile -- which does this undesirable things, like using TARGET_ARCH, for OS names -- and instead uses a simple pmake Makefile to get the job done. A few examples are as follows: 1. http://support.freenas.org/ticket/1144 , comments 3 and 5. 2. http://forums.freenas.org/showthread.php?2050-Dynamic-DNS-problem 3. http://forums.freenas.org/showthread.php?5078-8-0-3-RELEASE-coming-soon&p=19721&viewfull=1#post19721 >How-To-Repeat: I don't have clear reproduction steps for the issue. >Fix: Patch attached with submission follows: diff --exclude '*.orig' -Naur dns/inadyn/Makefile dns/inadyn/Makefile --- dns/inadyn/Makefile 2009-07-10 16:23:38.000000000 -0700 +++ dns/inadyn/Makefile 2012-01-07 20:04:28.202978310 -0800 @@ -7,7 +7,7 @@ PORTNAME= inadyn PORTVERSION= 1.96.2 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= dns MASTER_SITES= http://www.inatech.eu/inadyn/ \ ${MASTER_SITE_LOCAL} @@ -21,34 +21,29 @@ USE_RC_SUBR= inadyn USE_ZIP= yes USE_DOS2UNIX= yes -USE_GMAKE= yes -MAKEFILE= makefile - -MAN8= inadyn.8 -MAN5= inadyn.conf.5 -MANCOMPRESSED= no PORTDOCS= readme.html PLIST_FILES= bin/inadyn NO_INSTALL_MANPAGES=yes +MAKE_JOBS_SAFE= yes +MAKEFILE= ${FILESDIR}/BSDmakefile + +MAKE_ENV+= MANDIR=${MANPREFIX}/man + post-extract: ${MV} ${WRKDIR}/${PORTNAME} ${WRKDIR}/${PORTNAME}-${PORTVERSION} post-patch: - @${REINPLACE_CMD} -e 's|gcc|$$\(CC\)|g' ${WRKSRC}/makefile ${REINPLACE_CMD} -e "s,%%PREFIX%%,${PREFIX},g" \ ${WRKSRC}/man/inadyn.8 ${WRKSRC}/readme.html \ ${WRKSRC}/src/dyndns.h -do-install: +pre-install: .if !defined(NOPORTDOCS) ${MKDIR} ${DOCSDIR} ${INSTALL_MAN} ${WRKSRC}/${PORTDOCS} ${DOCSDIR} .endif - ${INSTALL_SCRIPT} ${WRKSRC}/bin/linux/inadyn ${PREFIX}/bin - ${INSTALL_SCRIPT} ${WRKSRC}/man/inadyn.8 ${MANPREFIX}/man/man8 - ${INSTALL_SCRIPT} ${WRKSRC}/man/inadyn.conf.5 ${MANPREFIX}/man/man5 .include diff --exclude '*.orig' -Naur dns/inadyn/files/BSDmakefile dns/inadyn/files/BSDmakefile --- dns/inadyn/files/BSDmakefile 1969-12-31 16:00:00.000000000 -0800 +++ dns/inadyn/files/BSDmakefile 2012-01-07 20:02:28.322979665 -0800 @@ -0,0 +1,16 @@ +PROG= inadyn + +MAN5= inadyn.conf.5 + +MAN8= inadyn.8 + +SRCS= base64utils.c dyndns.c errorcode.c get_cmd.c http_client.c ip.c main.c os.c \ + os_psos.c os_unix.c os_windows.c tcp.c inadyn_cmd.c + +.PATH: man src + +WARNS= 2 + +BINDIR= ${PREFIX}/bin + +.include >Release-Note: >Audit-Trail: >Unformatted: