From nobody Thu Oct 14 14:25:37 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8BDE5180B487; Thu, 14 Oct 2021 14:25:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HVWsJ66jJz4R2V; Thu, 14 Oct 2021 14:25:40 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf33.google.com with SMTP id j12so3801008qvk.12; Thu, 14 Oct 2021 07:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hHvhfKzLOxDlgXDH50FElTuOqXiQNj42BPP6FlGLkXs=; b=TrFtu+kxi0AUd5zho6W9nnHwrAgSb0Lp3goxJczJT23tmlToiABUCgHsCf79Akfuar mO2d3SFJfKWNzE+rG5IVgkWdoHjqDb9GxUYZCdwfEGnT3XtI0ZzzlTb3h6jpgGEakmT/ wyNAM9kTG4/wGIlTBLfbNZCN3dNTJlYjlzUOD3tbHFfSEJmQNjoqPWmGHe7XQDT4/oja Li5C1ZgOCSEtZD3tvSKNrG/5HRT3IlS44PpwHEXAhPCb0m0eJjE5Qd84cF4x8xZ0o6R7 w6nqz4nN8KGXoAxzPLrBvvAKbGYmWqx6B8l5fyvvbWSuDXuBvXJSKH1TEYohf2Xk0+cf xmOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=hHvhfKzLOxDlgXDH50FElTuOqXiQNj42BPP6FlGLkXs=; b=sOk5LBN0eFu7X9+rbDUyKOxUd9p28ghyQDUmCbeU2QxM6dIipgk5/XFD1nSlyEMO6j r5AIZLVOEQaJSZ5mCSFRvw61f6QzKkOBhOt8SJ8mzFFPb2BDgKlXBKGTtISYGF5nU7Hi INoYrFleiW0b1rWAG7l2NFxyz/VjlvHjVcw5uocpNXbrIBr5hNFmwNi8gvsw5wDgwcdH N3yHouLBF98T1BinB73lAHaKAMA/Q67G3DorFXViGA+tjgDCN96WdFUk+o4TPDkvQsHV uN22nQCaUQP9ndf3C5r2yDGFFiFrL50+qZqGNP9HADLBDksbfzwZL7tbNj7lpgybiqit zlxQ== X-Gm-Message-State: AOAM533FIFIAIdlSz8ztWX3jeIPd140eBGeeIC/2HTjYKAW9+tM1X/Pj bx7atEuDNxpHniIETmoYeVxzAXe4ccw= X-Google-Smtp-Source: ABdhPJx1wsVSDIu0Q/0aEg+pp9fwyOu8v2RzzAt53ODfm38wtkaUad8Ci9wfPgI3n7kBTenWXMfg+Q== X-Received: by 2002:a05:6214:ac8:: with SMTP id g8mr5743989qvi.32.1634221539997; Thu, 14 Oct 2021 07:25:39 -0700 (PDT) Received: from nuc ([142.126.186.191]) by smtp.gmail.com with ESMTPSA id a201sm1359959qkg.67.2021.10.14.07.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 07:25:39 -0700 (PDT) Sender: Mark Johnston Date: Thu, 14 Oct 2021 10:25:37 -0400 From: Mark Johnston To: Hartmut Brandt Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ded77e0237a8 - main - Allow the BPF to be select for write. This is needed for boost:asio which otherwise fails to handle BPFs. Reviewed by: ae Differential Revision: https://reviews.freebsd.org/D31967 Message-ID: References: <202110130754.19D7so0V049456@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202110130754.19D7so0V049456@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4HVWsJ66jJz4R2V X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=TrFtu+kx; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f33 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [1.82 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; NEURAL_HAM_MEDIUM(-0.04)[-0.036]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; LONG_SUBJ(1.54)[206]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_SPAM_LONG(1.00)[1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f33:from]; NEURAL_HAM_SHORT(-0.98)[-0.984]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N On Wed, Oct 13, 2021 at 07:54:50AM +0000, Hartmut Brandt wrote: > The branch main has been updated by harti: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ded77e0237a8534230746031f373d8a8ae80cdaa > > commit ded77e0237a8534230746031f373d8a8ae80cdaa > Author: Hartmut Brandt > AuthorDate: 2021-10-10 15:03:51 +0000 > Commit: Hartmut Brandt > CommitDate: 2021-10-10 15:03:51 +0000 > > Allow the BPF to be select for write. This is needed for boost:asio > which otherwise fails to handle BPFs. > Reviewed by: ae > Differential Revision: https://reviews.freebsd.org/D31967 Hi, syzbot found a bug in this change: https://syzkaller.appspot.com/bug?id=a99f705b2b8b854d70ec4d47eed481c90046bd3c It seems that filt_bpfwrite() needs to check whether d->bd_bif == NULL before dereferencing.