From nobody Fri Apr 24 20:38:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2PvJ1DqCz6bDT5; Fri, 24 Apr 2026 20:39:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2PvJ0GhWz3VJB; Fri, 24 Apr 2026 20:39:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777063148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cUmttE2sgAcgm2q8zNAihXmnSKXjdY+PEK8LP8b3GX8=; b=h7oYRzcRQwjja2TDGUoZKfUh8WT0hDumlLnlNRHvPqDwpccTwkbwry+3YzAegQpfVQXBa8 Pi0AeZ5UvUs/lXEmX6HFYEo2Y8ObwL7bEg0E+30Pk85DqW+l7OUwFImkAGaDZ07FF7PKOh 2QPdgW6zbPvZ2MCXrslFsvy/7A/13onzHAnCq1wYt4jeilmFX/W9KXyF6paBywnVMTrEws Auq+n5Wi+860lkLLgO2og+1iiMAUXAomHlEzjza1rcPYaKNQB6/0yyZQRlMRNhkYHex1u0 n9RJIQwatYYWTJKMZyRr8ZtnYPeRT/n8b10pXZPJWhq3ypkmG/icp5+35DXpJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777063148; a=rsa-sha256; cv=none; b=AAUDslN8RIcGkJrcSgu5wyIfvwn/aqFBZqoi0tYZoIkLx5YGC+a14PXKzVIQc8XRoK2qwO nEM4lbqlARrElcJFjV7YE0Ia3ZeJEvfSiDem5DjeuJCDpu2eih2kF6GYMcnlaQWt3pIIK+ pFBNKLJBdSGI5XlBGLPFuA51PP7leFzjNCnWj08Dbv0POTMhzSUWOv3Rsc0YSsWzC2HTxr V+lSlWnIGC83+BlPl6EFEioyK7Pi2O8UsJlrLMgHdByDvkd3LLfcpRddWPHBX2yf+feui9 rQU8tM1G/RZwM17EYMFerMYeGZJdecxlvjDQO8bTlkjreVaHGWIgNSMLKe+t1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777063148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cUmttE2sgAcgm2q8zNAihXmnSKXjdY+PEK8LP8b3GX8=; b=WwOJsOF1KoR01wRmWHqWX3oxezyXRzytbl36RPBgtqpmb17PZI8yLPhxp4j7xzY+FQzj2W kSzHGW/85FF4AFDAV6QKJpF52V7dFPcXefuXOIa+paaHJX3Yq2bbkpJ0/NaOc5K55vS+jV 3gBC/60ySJ0xvfT9lb4jmAiT70NdSpDOJGZN8vGuxx//XSabphGiJxvMj1yIdAHVXf8Uyi o/nK+oYXXprDyWDnKBMPkdMkPKeBLrQtG+CwZXocNJYxeCiDTqJ0QqPgKf5hUcBktvu7JA Yb9ZcpkFQxxZuNKb0fOta7rI02rJTTJc7prB8JT+G7PmMYgDn4PEDva/g8p8Vw== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g2PvH5xswzKq7; Fri, 24 Apr 2026 20:39:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 66AF3A64805; Fri, 24 Apr 2026 20:38:38 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E51282D029D8; Fri, 24 Apr 2026 20:39:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id kGAan4U3p6IZ; Fri, 24 Apr 2026 20:38:59 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 99AA82D029EA; Fri, 24 Apr 2026 20:38:59 +0000 (UTC) Date: Fri, 24 Apr 2026 20:38:59 +0000 (UTC) From: "Bjoern A. Zeeb" To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org cc: John Baldwin Subject: Re: git: 93d301d95ab2 - main - Remove -fms-extensions throughout the tree In-Reply-To: <69ebd450.36574.1b31c920@gitrepo.freebsd.org> Message-ID: <889qsnp1-5qp7-8254-298-s84q10216969@mnoonqbm.arg> References: <69ebd450.36574.1b31c920@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 24 Apr 2026, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=93d301d95ab230ea159b21b5412aac2ce5362ac5 > > commit 93d301d95ab230ea159b21b5412aac2ce5362ac5 > Author: Bjoern A. Zeeb > AuthorDate: 2026-02-03 01:51:40 +0000 > Commit: Bjoern A. Zeeb > CommitDate: 2026-04-24 20:36:15 +0000 > > Remove -fms-extensions throughout the tree > > During a discussion about using -fms-extensions jhb pointed out that > we have them enabled in the kernel for gcc by default (even multiple > times in one part). I had missed all that and clang still failed on > my use case (needing another option). > > The original cause for enabling them for our tree back then was that > we needed to support C11 anonymous struct/unions. > Our in-tree gcc 4.2.1, despite later patches, needed the > -fms-extensions to support these even though this was not the expected > use case for that option ( cc4a90c445aa0 enabled it globally for the > kernel). > clang at that time (or at least when it became default for 10.0) > already was fine (with C11). > > Any later gcc (4.6.0 onwards) did not need that option anymore, even > when compiled for -std=iso9899:1990 (which does not support anonymous > structs/unions) unless one would add -pedantic (see gcc git 4bdd0a60b27a). > This is also the reason why userland cddl sources now compile with the > option removed despite CSTD=c99. > > The only driver which needed the option recently was ccp, but that was > fixed in 8d3f41dbcb2a by jhb. > > So cleanup all uses cases of -fms-extensions for the moment as they are > no longer needed given all compilers currently supported seem to be > fine without them and gcc-4.2.1 was removed from the tree in stable/13 > in 2020 (a9854bc3812b). I should also say there was a lot of testing and exchaning emails with jhb back and forther in order (for me) to understand when and why we needed this (and when no longer). Thanks a lot jhb! > Reported by: jhb (all this but possibly the world CDDL parts) > Sponsored by: The FreeBSD Foundation > MFC after: 3 days > Reviewed by: emaste (earlier), imp, jhb, glebius > Differential Revision: https://reviews.freebsd.org/D55072 -- Bjoern A. Zeeb r15:7