From owner-freebsd-ports@FreeBSD.ORG Wed Jan 9 17:34:48 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05E7D16A46C; Wed, 9 Jan 2008 17:34:48 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (penna-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 98B3213C448; Wed, 9 Jan 2008 17:34:47 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.2/8.14.2) with ESMTP id m09Ha0iL059565; Wed, 9 Jan 2008 12:36:00 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: "Alexandre \"Sunny\" Kovalenko" In-Reply-To: <1199893999.756.29.camel@RabbitsDen> References: <1199893999.756.29.camel@RabbitsDen> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VemPnshHAVr639ushSdb" Organization: MarcusCom, Inc. Date: Wed, 09 Jan 2008 12:35:04 -0500 Message-Id: <1199900104.304.28.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on creme-brulee.marcuscom.com Cc: ports@freebsd.org, gnome@freebsd.org, Alexander Nedotsukov Subject: Re: [patch] glib20, UTF-8 and string collation X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 17:34:48 -0000 --=-VemPnshHAVr639ushSdb Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2008-01-09 at 10:53 -0500, Alexandre "Sunny" Kovalenko wrote: > I have seen recent commit WRT string collation in devel/glib20 by > marcus, so I have decided to check if there is an interest to fix SEGV > in g_utf8_collate when it is given 8-bit non-UTF-8 string(s) to collate. Any commits I have made in the area of UTF-8 are completely accidental. I am not the UTF-8 guy. Both bland and jylefort have expressed interest in this. Perhaps one of them will comment. >=20 > Good (but by no means only) example of this would be using Evolution to > open mailbox with the mix of KOI-8, CP1251 and UTF-8 message subjects > and order them by the subject. Admittedly, I do not know whether there > are special symbols that trigger the situation or any mix would do. vova > at fbsd ru posted test case mailbox under the link below. >=20 > Full discussion including my first approach to fix this problem could be > found here >=20 > http://bugzilla.gnome.org/show_bug.cgi?id=3D492389 >=20 > Slightly different approach is attached to this E-mail. I'm not sure why the malloc and copy. Why not just use g_strdup()? >=20 > Without either patch, my Evolution will core dump on start-up.=20 >=20 > First patch was rejected by gnome folks with the recommendation "Don't > do that", which, unfortunately, is not that easy to follow ;) >=20 > Any comments from people with the knowledge of gnome, UTF-8 and string > collation will be greatly appreciated. I'm hoping someone like bland chimes in here. Touching glib in such a way makes me nervous, but bland has had experience, especially with Cyrillic, so maybe he can offer some additional tips or insight. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-VemPnshHAVr639ushSdb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHhQXEb2iPiv4Uz4cRAgnPAKCjG2DNvrzU8MJNG7UGt3qoUytI0ACbB6cK +IuJ047ghlGithkFbovyQxw= =ztkG -----END PGP SIGNATURE----- --=-VemPnshHAVr639ushSdb--