Date: Fri, 17 Jan 2025 19:38:45 +0100 From: Moin Rahman <bofh@freebsd.org> To: =?utf-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a8d366898894 - main - textproc/docproj: remove gnuplot-lite dependency Message-ID: <AD85BA62-D3E5-4563-8E33-80413F24F991@freebsd.org> In-Reply-To: <CAGwOe2Yy77o3kLtChNoAMszKzh2ecUDJHbs4k9mizhGOuv_a2A@mail.gmail.com> References: <CAGwOe2bTFU5Z68BuZ_zy9oYfLt2UWaTLco%2B8e4q_QNuxizxojA@mail.gmail.com> <26434658-5E5B-4197-890A-2B926AA2A487@freebsd.org> <CAGwOe2Yy77o3kLtChNoAMszKzh2ecUDJHbs4k9mizhGOuv_a2A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_FA555187-7727-45F0-8954-46D90D3F4C34 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 17, 2025, at 7:11 PM, Fernando Apestegu=C3=ADa = <fernape@freebsd.org> wrote: >=20 >=20 >=20 > On Thu, Jan 16, 2025 at 1:21=E2=80=AFPM Moin Rahman <bofh@freebsd.org> = wrote: >=20 >=20 >> On 16 Jan 2025, at 13:02, Fernando Apestegu=C3=ADa = <fernape@freebsd.org> wrote: >>=20 >> =EF=BB=BF >>=20 >> On Thu, Jan 16, 2025 at 8:56=E2=80=AFAM Moin Rahman = <bofh@freebsd.org> wrote: >>=20 >>=20 >> > On Jan 16, 2025, at 08:41, Fernando Apestegu=C3=ADa = <fernape@FreeBSD.org> wrote: >> > >> > The branch main has been updated by fernape: >> > >> > URL: = https://cgit.FreeBSD.org/ports/commit/?id=3Da8d3668988945bf23844a1733da214= 113e08d6ec >> > >> > commit a8d3668988945bf23844a1733da214113e08d6ec >> > Author: Fernando Apestegu=C3=ADa <fernape@FreeBSD.org> >> > AuthorDate: 2025-01-14 17:26:26 +0000 >> > Commit: Fernando Apestegu=C3=ADa <fernape@FreeBSD.org> >> > CommitDate: 2025-01-16 07:41:00 +0000 >> > >> > textproc/docproj: remove gnuplot-lite dependency >> > >> > It was a leftover from the previous docproj. >> > --- >> > textproc/docproj/Makefile | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/textproc/docproj/Makefile b/textproc/docproj/Makefile >> > index 6d362be1878a..a0b3c298573c 100644 >> > --- a/textproc/docproj/Makefile >> > +++ b/textproc/docproj/Makefile >> > @@ -1,5 +1,6 @@ >> > PORTNAME=3D docproj >> > PORTVERSION=3D 4.1.9 >> > +PORTREVISION=3D 1 >> > CATEGORIES=3D textproc >> > >> > MAINTAINER=3D doceng@FreeBSD.org >> > @@ -7,7 +8,6 @@ COMMENT=3D Meta-port for the FreeBSD Documentation = Project >> > WWW=3D https://www.freebsd.org/docproj >> > >> > RUN_DEPENDS=3D asciidoctor:textproc/rubygem-asciidoctor \ >> > - gnuplot-lite>0:math/gnuplot-lite \ >> > gohugo>=3D0.133.1,1:www/gohugo \ >> > rougify:textproc/rubygem-rouge \ >> > rubygem-asciidoctor-diagram>0:textproc/rubygem-asciidoctor-diagram >>=20 >> I don't think this is correct. gnuplot was used to generate the graph >> of number of ports here: >>=20 >> https://docs.freebsd.org/en/books/dev-model/#sub-project-ports >>=20 >> Interesting. I don't see any invocations to gnuplot in any of the = Makefiles. >> Also, I don't have any gnuplot* packages in my system and I regularly = build the documentation just fine: >>=20 >> $ DOC_LANG=3Den make >> --------------------------------------------------------------- >> Building the documentation >> included languages: en >> excluded languages: bn-bd da de el es fr hu id it ja ko mn nl pl = pt-br ru tr zh-cn zh-tw >> --------------------------------------------------------------- >> /usr/local/bin/ruby ./tools/global-pgpkeys-creator.rb >> HUGO_DISABLELANGUAGES=3D" bn-bd da de el es fr hu id it ja ko mn nl = pl pt-br ru tr zh-cn zh-tw" /usr/local/bin/hugo --minify >> Start building sites =E2=80=A6 >> hugo v0.140.2+extended freebsd/amd64 = BuildDate=3D2024-12-30T17:44:54Z+0000 VendorInfo=3Dfreebsd >>=20 >>=20 >> | EN >> -------------------+------- >> Pages | 1187 >> Paginator pages | 0 >> Non-page files | 0 >> Static files | 856 >> Processed images | 0 >> Aliases | 1 >> Cleaned | 0 >>=20 >> Total in 200805 ms >> Where is that file generated? > It=E2=80=99s not in a Makefile. Eventually rubygem-asciidoctor-diagram = calls it to generate the diagram. Search for a file where = asciidoctor-diagram is defined as a plugin. I am travelling today and = will share the details at night. >=20 >=20 > The reason the image was not properly loaded is because the syntax was = wrong in d7957d161fd when this change was introduced. > I just fixed it in 6abcb860ac: >=20 > -.Number of ports added between 1995 and 2022 [[fig-ports]] > -image::portsstatus.svg > +.Number of ports added between 1995 and 2022 > +[[fig-ports]] > +image::portsstatus.svg[Refer to paragraphs below for a screen-reader = friendly version.] >=20 > I don't have any gnuplot packages in my system: >=20 > $ pkg info -x '.*plot.*' > pkg: No package(s) matching .*plot.* >=20 > and yet with that change "make run" now shows the picture in the = documentation. > The CI for the documentation tree needs fixing = (https://github.com/freebsd/freebsd-ci/pull/178) so the image might not = show yet in docs.freebsd.org. >=20 > The image in question is generated by = https://people.freebsd.org/~bofh/dropzone/dev-model.sh, which reads at = the beginning:# This script will inform the total number of committers = per repo at > # the end of the run. This information should be manually updated in > # the file documentation/content/en/books/dev-model/_index.adoc > According to git log, the generated image was last updated in 2022, = and I can tell you I've built the whole tree a number of times since = 2022 :-) > Are you sure you uploaded it to the repo and hook it to the build? >=20 > Cheers. >=20 I think this was not completed then. :'( Kind regards, Moin --Apple-Mail=_FA555187-7727-45F0-8954-46D90D3F4C34 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmeKo7VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJFe/w//VRIl9gANpOFhj8ZfkV9+M6dmODT8zrJu3aayCyJpcKxgzksaZXIuu9xd e4WTJkn4LEf5u5A2FXVQl2XoUYLqZzDzO3wuSKwGIdKDMW6aFZb3MIoygvZ+Y8LA 2K1uQkArSrIIi2vicO/sf0qkxf97CTkD1rTkIKO9ymn4fGqNIAuOUXcds9r4oH5y M4l9qij5sIPHMgOn4H4erAdvfqVcrhsDg37/tgjYee5QOT10S5DmiuBBnHekxtht fba7U5IK1Pq/rAcjlGxSulZXNzRG/MFxG18O3PeufIqHmnndcK3zBmwV7Td++1eE lDMkB1djsB2SmTXe0eUZJs1uDJ1OTX8HCX3KCleYaOVoIfbZ472LnihEYdcn0qTn i6YN1X7rYEeMzbmp4efWKiKgZBDjbg47/+6dG9hNv1Uz4milrF7eiaja96Ru8Da+ Eg5tBYSt/a+QqOZBKflgzSdbbuodN/ObajsofNPswGR45ih/0Xgv8r7QOGBS7UFM GrotfF/8bUhjbMNwiZHBtIuJcp7zCZSpGFaAzTZ+Do1H6rKZInL69VQl8xiDTikw VSzyGzWAQ4efue8cnaxTAJgbbU17BnGEsPcxQQSFBVGMsXTpR5ZDLzWUqg1H6uOz GAMbQSRNvZrJy7KGq28Dcs3iiC3yQWkmEVXdjumnsj3/l3/6+uk= =mhGL -----END PGP SIGNATURE----- --Apple-Mail=_FA555187-7727-45F0-8954-46D90D3F4C34--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AD85BA62-D3E5-4563-8E33-80413F24F991>