From owner-svn-src-head@freebsd.org  Wed Feb 15 10:06:51 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 525B8CDFEC4;
 Wed, 15 Feb 2017 10:06:51 +0000 (UTC)
 (envelope-from prvs=21221c659=roger.pau@citrix.com)
Received: from SMTP.EU.CITRIX.COM (smtp.ctxuk.citrix.com [185.25.65.24])
 (using TLSv1.2 with cipher RC4-SHA (128/128 bits))
 (Client CN "mail.citrix.com",
 Issuer "DigiCert SHA2 Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5466BBF;
 Wed, 15 Feb 2017 10:06:49 +0000 (UTC)
 (envelope-from prvs=21221c659=roger.pau@citrix.com)
X-IronPort-AV: E=Sophos;i="5.35,165,1484006400"; d="scan'208";a="40800941"
Date: Wed, 15 Feb 2017 10:06:37 +0000
From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
To: Sean Bruno <sbruno@FreeBSD.org>
CC: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>,
 <svn-src-head@freebsd.org>
Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf
 sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules
 sys/modules/em sys/modules/igb sys/powerpc/conf
Message-ID: <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com>
References: <201701100323.v0A3NMAI045868@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <201701100323.v0A3NMAI045868@repo.freebsd.org>
User-Agent: NeoMutt/20170206 (1.7.2)
X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To
 AMSPEX02CL02.citrite.net (10.69.22.126)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Feb 2017 10:06:51 -0000

On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote:
> Author: sbruno
> Date: Tue Jan 10 03:23:22 2017
> New Revision: 311849
> URL: https://svnweb.freebsd.org/changeset/base/311849
> 
> Log:
>   Migrate e1000 to the IFLIB framework:
>   - em(4) igb(4) and lem(4)
>   - deprecate the igb device from kernel configurations
>   - create a symbolic link in /boot/kernel from if_em.ko to if_igb.ko

This linking causes mfsBSD to choke when building an image from HEAD. It tries
to issue the following command:

${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot

Which fails when finding the symbol link. I can send a patch to change that to
-Rp, which would work fine, but wouldn't it be better to either completely
remove if_igb.ko, or simply copy if_em.ko to if_igb.ko?

I'm wondering if for example anyone strips down it's /boot/kernel/ manually, by
removing unused modules, and what would happen if if_em.ko is removed but not
if_igb.ko.

Roger.