From owner-freebsd-current Sat Jun 20 13:03:08 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA01267 for freebsd-current-outgoing; Sat, 20 Jun 1998 13:03:08 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from smtp03.primenet.com (daemon@smtp03.primenet.com [206.165.6.133]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA01252 for ; Sat, 20 Jun 1998 13:03:02 -0700 (PDT) (envelope-from tlambert@usr02.primenet.com) Received: (from daemon@localhost) by smtp03.primenet.com (8.8.8/8.8.8) id NAA11281; Sat, 20 Jun 1998 13:03:04 -0700 (MST) Received: from usr02.primenet.com(206.165.6.202) via SMTP by smtp03.primenet.com, id smtpd011198; Sat Jun 20 13:02:54 1998 Received: (from tlambert@localhost) by usr02.primenet.com (8.8.5/8.8.5) id NAA17957; Sat, 20 Jun 1998 13:02:49 -0700 (MST) From: Terry Lambert Message-Id: <199806202002.NAA17957@usr02.primenet.com> Subject: Re: Bogus errno twiddling by lstat... To: joelh@gnu.org Date: Sat, 20 Jun 1998 20:02:49 +0000 (GMT) Cc: tlambert@primenet.com, fenner@parc.xerox.com, peter@netplex.com.au, current@FreeBSD.ORG In-Reply-To: <199806201949.OAA17700@detlev.UUCP> from "Joel Ray Holveck" at Jun 20, 98 02:49:02 pm X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > If, however, you don't like our malloc's current implementation, and > think that errno should be saved and restored across a successful > call, and that the lost cycles would be worthwhile, then diffs would > be perfectly welcome, I'm sure. Since the malloc.conf file is unnecessarily being looked for in the printf case (since ld.so already caused it to be looked for, and didn't find it), I think the redundant call to llok for it is certainly worth removing. I would also not save and restore state, except in anticipation of an error. If the cached value were being used (as it should be), then the malloc.conf reference shouldn't have been tried (and not being tried, the errno would not be in danger of being blown). Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message