From owner-freebsd-current@FreeBSD.ORG  Wed Oct 26 08:31:53 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 028C316A41F
	for <current@FreeBSD.org>; Wed, 26 Oct 2005 08:31:53 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4A47C43D48
	for <current@FreeBSD.org>; Wed, 26 Oct 2005 08:31:50 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9Q8Vmoi091284
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 26 Oct 2005 12:31:48 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id j9Q8VlWa091283;
	Wed, 26 Oct 2005 12:31:48 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Wed, 26 Oct 2005 12:31:47 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Peter Holm <peter@holm.cc>
Message-ID: <20051026083147.GA41520@cell.sick.ru>
References: <20051026072337.GA31319@peter.osted.lan>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="3O1VwFp74L81IIeR"
Content-Disposition: inline
In-Reply-To: <20051026072337.GA31319@peter.osted.lan>
User-Agent: Mutt/1.5.6i
Cc: current@FreeBSD.org
Subject: Re: panic: mutex nfsd_mtx owned at nfsserver/nfs_serv.c:2160
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2005 08:31:53 -0000


--3O1VwFp74L81IIeR
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline

  Peter,

On Wed, Oct 26, 2005 at 09:23:37AM +0200, Peter Holm wrote:
P> While stress testing RELENG_6_0 with a nfs mounted file system on a 
P> box running HEAD from Oct 24 13:21 UTC I got this panic (on HEAD):
P> http://people.freebsd.org/~pho/stress/log/nfsd.html

let's try out this one.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE

--3O1VwFp74L81IIeR
Content-Type: text/plain; charset=koi8-r
Content-Disposition: attachment; filename="nfs_serv.c.diff"

Index: nfs_serv.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsserver/nfs_serv.c,v
retrieving revision 1.156
diff -u -r1.156 nfs_serv.c
--- nfs_serv.c	17 Apr 2005 16:25:36 -0000	1.156
+++ nfs_serv.c	26 Oct 2005 08:00:26 -0000
@@ -2092,6 +2092,7 @@
 	tl = nfsm_dissect_nonblock(u_int32_t *, NFSX_UNSIGNED);
 	vtyp = nfsv3tov_type(*tl);
 	if (vtyp != VCHR && vtyp != VBLK && vtyp != VSOCK && vtyp != VFIFO) {
+		NFSD_UNLOCK();
 		error = NFSERR_BADTYPE;
 		goto out;
 	}
@@ -2108,6 +2109,7 @@
 	 * Iff doesn't exist, create it.
 	 */
 	if (nd.ni_vp) {
+		NFSD_UNLOCK();
 		error = EEXIST;
 		goto out;
 	}

--3O1VwFp74L81IIeR--