From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 27 18:30:35 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7655A16C963 for ; Sat, 27 May 2006 18:30:35 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C040443D81 for ; Sat, 27 May 2006 18:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k4RIUKeD055357 for ; Sat, 27 May 2006 18:30:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k4RIUKNm055356; Sat, 27 May 2006 18:30:20 GMT (envelope-from gnats) Resent-Date: Sat, 27 May 2006 18:30:20 GMT Resent-Message-Id: <200605271830.k4RIUKNm055356@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Ovens Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1AA016C976 for ; Sat, 27 May 2006 18:23:24 +0000 (UTC) (envelope-from root@magichamster.com) Received: from ptb-relay03.plus.net (ptb-relay03.plus.net [212.159.14.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31DE143D55 for ; Sat, 27 May 2006 18:23:24 +0000 (GMT) (envelope-from root@magichamster.com) Received: from [80.229.231.20] (helo=movens.plus.com) by ptb-relay03.plus.net with esmtp (Exim) id 1Fk3Ra-0002fm-Lt for FreeBSD-gnats-submit@freebsd.org; Sat, 27 May 2006 19:23:22 +0100 Received: by postbag.magichamster.com (Postfix, from userid 0) id 9930C1CC7C; Sat, 27 May 2006 19:24:22 +0100 (BST) Message-Id: <20060527182422.9930C1CC7C@postbag.magichamster.com> Date: Sat, 27 May 2006 19:24:22 +0100 (BST) From: Mark Ovens To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/98032: [PATCH] sysutils/portmanager dumps core if not run as root X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark Ovens List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 May 2006 18:30:51 -0000 >Number: 98032 >Category: ports >Synopsis: [PATCH] sysutils/portmanager dumps core if not run as root >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 27 18:30:20 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Mark Ovens >Release: FreeBSD 6.1-RELEASE i386 >Organization: >Environment: System: FreeBSD redshift 6.1-RC FreeBSD 6.1-RC #0: Mon May 1 14:05:04 BST 2006 root@redshift:/usr/obj/usr/src/sys/REDSHIFT i386 >Description: If portmanager is run as a user other than root it dumps core because the user does not have write perms for /usr/local/share/portmanager/ignore.db. This is not very graceful! /home/mark{4}% portmanager touch: /usr/local/share/portmanager/ignore.db: Permission denied MGdbCreate error, lstat of /usr/local/share/portmanager/ignore.db failed lstat: No such file or directory Assertion failed: (0), function MGdbCreate, file MGdbCreate.c, line 64. Abort (core dumped) /home/mark{5}% >How-To-Repeat: Run portmanager as a non-root user >Fix: Apply the following patch --- portmanager.c.diff begins here --- --- portmanager/portmanager.c.orig Tue Dec 13 00:20:58 2005 +++ portmanager/portmanager.c Sat May 27 18:08:32 2006 @@ -34,7 +34,13 @@ int main( int argc, char** argv, char** argp) { int errorCode = 0; - + + if ( getuid() != 0 ) + { + fprintf( stderr, "%s must be run as root\n", argv[0] ); + exit( 1 ); + } + errorCode = MGPMrCommandLine( argc, (char**)argv, (char**)argp ); exit( errorCode ); } --- portmanager.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: