From owner-p4-projects@FreeBSD.ORG Thu Aug 21 00:31:02 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B7D1316A4C1; Thu, 21 Aug 2003 00:31:01 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47D4916A4BF for ; Thu, 21 Aug 2003 00:31:01 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DDC5443FD7 for ; Thu, 21 Aug 2003 00:31:00 -0700 (PDT) (envelope-from marcel@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h7L7V00U040661 for ; Thu, 21 Aug 2003 00:31:00 -0700 (PDT) (envelope-from marcel@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h7L7V0tt040658 for perforce@freebsd.org; Thu, 21 Aug 2003 00:31:00 -0700 (PDT) Date: Thu, 21 Aug 2003 00:31:00 -0700 (PDT) Message-Id: <200308210731.h7L7V0tt040658@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to marcel@freebsd.org using -f From: Marcel Moolenaar To: Perforce Change Reviews Subject: PERFORCE change 36551 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2003 07:31:02 -0000 http://perforce.freebsd.org/chv.cgi?CH=36551 Change 36551 by marcel@marcel_nfs on 2003/08/21 00:30:38 Aarrgghh. The interrupt issue on pluto1 and pluto2 are very likely not driver problems. I forgot we have a hack on the ia64 branch to deal with the fact that the non- legacy interrupts used by the UARTs are edge sensitive, active high. We really need to get that fixed in CVS... Affected files ... .. //depot/projects/uart/ia64/ia64/interrupt.c#4 edit Differences ... ==== //depot/projects/uart/ia64/ia64/interrupt.c#4 (text+ko) ==== @@ -266,9 +266,18 @@ struct sapic *sa = ia64_sapics[i]; if (irq < sa->sa_base || irq > sa->sa_limit) continue; + /* + * KLUDGE: Not all interrupts higher or equal to 16 are + * active low and level sensitive. We don't know yet how + * to check for this, so we hardcode the 2 cases we have + * wrong explicitly. This kludge is specific to the HP + * rx2600... + */ sapic_enable(sa, irq - sa->sa_base, vector, - (irq < 16) ? SAPIC_TRIGGER_EDGE : SAPIC_TRIGGER_LEVEL, - (irq < 16) ? SAPIC_POLARITY_HIGH : SAPIC_POLARITY_LOW); + ((irq < 16 || vector == 66 || vector == 67) + ? SAPIC_TRIGGER_EDGE : SAPIC_TRIGGER_LEVEL), + ((irq < 16 || vector == 66 || vector == 67) + ? SAPIC_POLARITY_HIGH : SAPIC_POLARITY_LOW)); } }