From owner-freebsd-current@FreeBSD.ORG Sat Jan 26 13:41:08 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D7271390 for ; Sat, 26 Jan 2013 13:41:08 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx1.freebsd.org (Postfix) with ESMTP id 9BFD4FBE for ; Sat, 26 Jan 2013 13:41:08 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id fw7so937719vcb.34 for ; Sat, 26 Jan 2013 05:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=UqsmCWeLuuZn0xe9Cuqa9jJ8LtH47RT+gJciSLtQsx4=; b=pFDf5SbTalRUe5fH4neEk404Jry31PMo3rQCpGK+7mDgq7izdBoearN4R5szYRR4mk Ci72DpWkVLe7J3B2xb/PUDWls+T0Ze0k5t35wHGUg9EuhLf6fKr6oGTsJXWY/71eAjrF WugDjYnbM0AucIQy99A3JByThpD0nMKJDKdu26tg3QuSxVixsU3vqr/R0G5qgiNeqE0p BzpYe6/j9vHG01oEobo+4Xtc2oRFrB39RcRM3sXIj8C9wMOph+SNcnG59ms6YCs5zmJQ Quprkr86llCdEeZCl5kkUilo3hk71ScfJSBh8JG5Jm3qB5wD6tZV0XEThmFOLnLXNeVI b2fw== MIME-Version: 1.0 X-Received: by 10.52.66.70 with SMTP id d6mr8320937vdt.30.1359207661589; Sat, 26 Jan 2013 05:41:01 -0800 (PST) Sender: davide.italiano@gmail.com Received: by 10.58.229.136 with HTTP; Sat, 26 Jan 2013 05:41:01 -0800 (PST) In-Reply-To: References: Date: Sat, 26 Jan 2013 05:41:01 -0800 X-Google-Sender-Auth: NTUyddzF1SXs51mBw7c4QSC1DfA Message-ID: Subject: Re: hwpmc support for Ivy Bridge Xeon From: Davide Italiano To: hiren panchasara Content-Type: text/plain; charset=ISO-8859-1 Cc: Fabien Thomas , freebsd-current , Jim Harris X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2013 13:41:08 -0000 On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara wrote: > I've tried to update hwpmc by adding support for xeon class of Ivy > bridge processors. > > Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) > > I do not have a reference machine to test with. Any help in that > regard would be appreciated. > > Here are the diffs against head (245927): > http://www.strugglingcoder.info/patches/hwpmc_ibx.txt > > Thanks, > Hiren > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >From a first look appears good -- I've a couple of observations though. I see your patch covers only core events -- am I missing something? Not really important, and I don't want to be pedantic here, but maybe this can be renamed to something less ugly: static int -iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri) +iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri) -- Davide