From owner-cvs-all@FreeBSD.ORG Thu Mar 29 04:11:00 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id E28B31065670; Thu, 29 Mar 2012 04:11:00 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 4C2B814DB68; Thu, 29 Mar 2012 04:11:00 +0000 (UTC) Message-ID: <4F73E0D3.90807@FreeBSD.org> Date: Wed, 28 Mar 2012 21:10:59 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Dirk Meyer References: <201203251429.q2PET8Bo038362@repoman.freebsd.org> In-Reply-To: <201203251429.q2PET8Bo038362@repoman.freebsd.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/miniupnpc/files miniupnpc.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 04:11:01 -0000 Overall this is not bad, just some small things that can wait till the next version if you prefer: 1. It needs a $FreeBSD$ 2. The lines after run_rc_command should be deleted. See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more info. Doug On 3/25/2012 7:29 AM, Dirk Meyer wrote: > dinoex 2012-03-25 14:29:08 UTC > > FreeBSD ports repository > > Added files: > net/miniupnpc/files miniupnpc.in > Log: > - add rc.d script > Submitted by: Andrey Chernov > Feature safe: yes > > Revision Changes Path > 1.1 +33 -0 ports/net/miniupnpc/files/miniupnpc.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/miniupnpc/files/miniupnpc.in >