From nobody Tue Jan 14 14:43:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YXX1n4FKfz5kmKN; Tue, 14 Jan 2025 14:43:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YXX1l4Km0z3glX; Tue, 14 Jan 2025 14:43:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736865819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSp33bLh7CF9MyjOIJmPZ0e4vztMZuqhX9UxGLNiLMk=; b=JTRQsp6p/TpqzRGgGOJWH5+0X9wLzLXSebuCSlcOwnpNwKaBf/wMt3b5kthQScpPE3lhP0 pzM+5PkoEWC2iikfk1Uwo32YnfmT/7EmLAeoKeyEnEmfWhFQgIBFRmDzL3Vko+6TsXF9rQ ai3/oleUl3VEoJUziFWCTPWA3ci777FgIxhGdKpvscWwlO5bOJc7kkCrYqIkTIMD0ElVp4 nd5bXHV0oiV/gvhALnz8i47kGgYKHZco8Lv5nV9lieCvz1reZFn8SRR8jzh3RIiyzG1vBZ KCotL10PNKZaI2sW6DSthoN0TVp8SceZ5RAaZvWhB7O4uF18JIjePOos9fk5KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736865819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSp33bLh7CF9MyjOIJmPZ0e4vztMZuqhX9UxGLNiLMk=; b=Pgv9bKKAYGCokMTPffeh4wHtcQ6X9817TAknXYTITwQ+tpdHIzchPYh7nYO2LGPugRgEqH A16j9jmul7ZCSYkbl3I0UsqYntAGxgEwnvYEBhRLs5Gd3zeWQtzyOUtZmiSGmAFYF5dAe2 I8UKEy643hZkPC0zHVZ71a5XKo6dJeINXfRshmyLhF8P1Yg60D60r4ee1XRhjGV7Svpik6 8BYNcTJsRs7GIh5G30Sjg5uRhxUum8S8uhEAmDthm7+jfhTgwSgAlWb3KIgPfgZpP0nnXa 93jZSEHl2uwDHQoGb1N7NOIByMVjs/aGKYXDTu5RCLqlTheO1DfW5bvjU7w+SA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736865819; a=rsa-sha256; cv=none; b=scRW+jLonRe6roYN6jDMJS4nnSIaSg6xcNRtpgjGbuZRfKejyA9EL9V0cjWzdwmYt186aZ 677YtIsL/cdghBxEqCifhF0Ye2oM8St4b3Ub1ogNxJ118oOdix4Vvfxb4RIjvE+wLwirfI ifUpeKChQQ3O+WWHhDBY4/5RzrTZR5aOOi8a+VJtc3K597CyQlktUMSVkxQdXPKk6tCnCH TO3Kp6oU75EMwKZkfwq9OqSzdN2VkDBYnHaMhIuJlo+c88UNo6n5XeteazBtATP0ORc+tM hQszFyz7LoNeKTqVtQNofg6uM6MwK1Feldj7B12WsvWk9gff6V62Q4MsvmNPaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YXX1l3xLkz1KYK; Tue, 14 Jan 2025 14:43:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50EEhd5u014394; Tue, 14 Jan 2025 14:43:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50EEhdmw014391; Tue, 14 Jan 2025 14:43:39 GMT (envelope-from git) Date: Tue, 14 Jan 2025 14:43:39 GMT Message-Id: <202501141443.50EEhdmw014391@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: f849557c06e5 - stable/14 - x86: Short-circuit ipi_all_but_self() on UP systems List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f849557c06e55e7ebedc1b5c873fdf5111587918 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f849557c06e55e7ebedc1b5c873fdf5111587918 commit f849557c06e55e7ebedc1b5c873fdf5111587918 Author: Mark Johnston AuthorDate: 2025-01-07 17:58:58 +0000 Commit: Mark Johnston CommitDate: 2025-01-14 14:14:42 +0000 x86: Short-circuit ipi_all_but_self() on UP systems Apparently this is required on old intel hw, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275086#c3 PR: 275086 Reviewed by: mav, kib Fixes: 279cd05b7e4d ("Use APIC_IPI_DEST_OTHERS for bitmapped IPIs too.") MFC after: 1 week Diagnosed by: Ben Wilber Differential Revision: https://reviews.freebsd.org/D48361 (cherry picked from commit 254a2b767f9a39f1541e0a07a70bbe269e86ad70) --- sys/x86/x86/mp_x86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/mp_x86.c b/sys/x86/x86/mp_x86.c index 11b11471d736..c52102e2de1e 100644 --- a/sys/x86/x86/mp_x86.c +++ b/sys/x86/x86/mp_x86.c @@ -1427,6 +1427,9 @@ ipi_all_but_self(u_int ipi) cpuset_t other_cpus; int cpu, c; + if (mp_ncpus == 1) + return; + /* * IPI_STOP_HARD maps to a NMI and the trap handler needs a bit * of help in order to understand what is the source.