From owner-cvs-all@FreeBSD.ORG Mon Apr 11 00:07:59 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F9E116A4D6; Mon, 11 Apr 2005 00:07:59 +0000 (GMT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id B988C43D45; Mon, 11 Apr 2005 00:07:58 +0000 (GMT) (envelope-from nectar@FreeBSD.org) Received: from gw.celabo.org (localhost [127.0.0.1]) by internal.gw.celabo.org (Postfix) with ESMTP id 4C6043E2C2B; Sun, 10 Apr 2005 19:07:54 -0500 (CDT) Received: from lum.celabo.org (usen-221x249x212x60.ap-US01.usen.ad.jp [221.249.212.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lum.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id E35273E2C2A; Sun, 10 Apr 2005 19:07:53 -0500 (CDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by lum.celabo.org (Postfix) with ESMTP id 4D12A71829; Mon, 11 Apr 2005 09:07:50 +0900 (JST) In-Reply-To: <8664yx2wwd.fsf@xps.des.no> References: <200504081119.j38BJoZf036618@repoman.freebsd.org> <6715759dfc36ac3b48dc3efe8cfcd07d@FreeBSD.org> <8664yx2wwd.fsf@xps.des.no> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Message-Id: Content-Transfer-Encoding: quoted-printable From: Jacques Vidrine Date: Mon, 11 Apr 2005 09:07:49 +0900 To: des@des.no (=?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?=) X-Mailer: Apple Mail (2.619.2) X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on hellblazer.celabo.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/rexecd rexecd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2005 00:07:59 -0000 On Apr 8, 2005, at 10:58 PM, Dag-Erling Sm=F8rgrav wrote: > Jacques Vidrine writes: >> Thanks for fixing, DES. Only, you have re-introduced some of the >> bugs. You need to use getpwnam_r or copy the contents of the = returned >> struct passwd before continuing. > > Hmm, actually it should be sufficient to re-getpwnam() after the call > to pam_setcred() in the child. There's nothing else that has the > potential to screw up pwd. Yes, it would be sufficient, but wasteful (^_^). But, I'm not too=20 concerned. (BTW, getpwnam is just a wrapper for getpwnam_r). Cheers, --=20 Jacques A Vidrine / NTT/Verio nectar@celabo.org / jvidrine@verio.net / nectar@freebsd.org