From owner-freebsd-ruby@FreeBSD.ORG Thu Oct 30 15:15:10 2014 Return-Path: Delivered-To: ruby@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1059FC9D; Thu, 30 Oct 2014 15:15:10 +0000 (UTC) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AA30F878; Thu, 30 Oct 2014 15:15:09 +0000 (UTC) Received: from mouf.net (swills@mouf [199.48.129.64]) by mouf.net (8.14.5/8.14.5) with ESMTP id s9UFF2wV092205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 30 Oct 2014 15:15:07 GMT (envelope-from swills@mouf.net) Received: (from swills@localhost) by mouf.net (8.14.5/8.14.5/Submit) id s9UFF2OD092204; Thu, 30 Oct 2014 15:15:02 GMT (envelope-from swills) Date: Thu, 30 Oct 2014 15:15:02 +0000 From: Steve Wills To: Andrey Chernov Subject: Re: Can't build ruby20 on -current: it doesn't honor WITHOUT_CDDL=yes Message-ID: <20141030151458.GE4395@mouf.net> References: <54520ED5.6040907@freebsd.org> <20141030101739.GD63624@ivaldir.etoilebsd.net> <5452123A.40108@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5452123A.40108@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Thu, 30 Oct 2014 15:15:07 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=HEADER_FROM_DIFFERENT_DOMAINS autolearn=unavailable autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mouf.net X-Virus-Scanned: clamav-milter 0.98.3 at mouf.net X-Virus-Status: Clean Cc: ports , ruby@freebsd.org, Baptiste Daroussin X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Oct 2014 15:15:10 -0000 On Thu, Oct 30, 2014 at 01:26:02PM +0300, Andrey Chernov wrote: > On 30.10.2014 13:17, Baptiste Daroussin wrote: > > On Thu, Oct 30, 2014 at 01:11:33PM +0300, Andrey Chernov wrote: > >> Hi. > >> I disable zfs and dtrace on my machine using WITHOUT_CDDL=yes in > >> /etc/src.conf > >> ryby20 port throw this error: > >> ... > >> checking for valgrind/memcheck.h... no > >> checking for strip... strip > >> configure: error: dtrace(1) is missing > >> ===> Script "configure" failed unexpectedly. > >> > >> I see you have sophisticated check depending on OS version for > >> CONFIGURE_ARGS+= --enable-dtrace > >> IMHO, it should be replaced to test dtrace binary presence instead. > >> > > > > To be previse the port should not care about WITHOUT_CDDL :) but it should > > detect if the host has dtrace or note, probably a > > .if exists(/usr/sbin/dtrace) > > CONFIGURE_ARGS+= --enable-dtrace > > .endif > > > > Should do the trick (to be tested of course :) > > Yes, the thing > .if exists(/usr/sbin/dtrace) > CONFIGURE_ARGS+= --enable-dtrace > .else > CONFIGURE_ARGS+= --disable-dtrace > .endif > works (at least for no dtrace case) The checks for OS version weren't meant to detect presence of dtrace, they were meant to detect presence of dtrace with usable USDT. Unfortunately, presence of /usr/sbin/dtrace doesn't necessarily mean USDT works. So, both checks need to be there. I'll take a look when I can, but if someone else gets there first, great. Steve