From owner-freebsd-ports@FreeBSD.ORG Sun Jun 5 14:57:18 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A803106566B for ; Sun, 5 Jun 2011 14:57:18 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 028FB8FC08 for ; Sun, 5 Jun 2011 14:57:17 +0000 (UTC) Received: by bwz12 with SMTP id 12so4213769bwz.13 for ; Sun, 05 Jun 2011 07:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=zJ0uR0IssQUzPBadQS0xMPKFGpAukFo2rm9wuKMLynM=; b=FxkaLGVO+VmF/f2h5/Ca1r2j1KNPpIvlbidPMsujgDvBJOa8h+y/D9ST6d4mJW7Y9s YL//o9pCWDZ9N1GEChayCG5WvWi/0wiwM4Qk419Yxi0oEmgW52shJceOPhBELX//7UIc G3rpNSip+r8YKQ3tJ2zojrHbtrBWXDWRwJw+E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=KO5Wz1cZ9cLB2UKL3R/I2wFSOYT7Vt/YBTj1NtAp117pIC3cSDVRjQwRaPH4X0duW4 SY6FCB1MEXtiPAB5IujQM3RWEJGsmmKYhYybdVbz3W4wPKHN+0RC2geL2+7swabMzkOQ +WvcyKzAnQhYwEfMOGOcLydgOl+M9bLEOhFO0= MIME-Version: 1.0 Received: by 10.204.36.129 with SMTP id t1mr3832068bkd.97.1307283946249; Sun, 05 Jun 2011 07:25:46 -0700 (PDT) Received: by 10.204.81.17 with HTTP; Sun, 5 Jun 2011 07:25:46 -0700 (PDT) In-Reply-To: <20110605022434.GB46823@DataIX.net> References: <20110603161358.GB1247@procyon.xvoid.org> <19946.7125.169246.84228@jerusalem.litteratus.org> <60F86515-B592-4B98-BE53-904206B6B183@lists.zabbadoz.net> <19946.11846.502201.644665@jerusalem.litteratus.org> <20110605012320.GA46823@DataIX.net> <20110605022434.GB46823@DataIX.net> Date: Sun, 5 Jun 2011 09:25:46 -0500 Message-ID: From: Scot Hetzel To: jhell@dataix.net, jharris@widomaker.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Robert Huff , freebsd-ports@freebsd.org Subject: Re: Fping with WITH_IPV6=YES X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jun 2011 14:57:18 -0000 On Sat, Jun 4, 2011 at 9:24 PM, Jason Hellenthal wrote: > > And if I might suggest, remove the old ifdef and replace with ... > > pre-extract: > .if defined(WITH_IPV6) > .undef WITH_IPV6 > =A0@${ECHO_MSG} "********************************************************= *************" > =A0@${ECHO_MSG} "*** IPV6 IS NOT ENABLED FOR net/fping, IT DOES NOT WORK = WITH IPV4 ***" > =A0@${ECHO_MSG} "*** =A0 =A0 =A0 =A0 =A0 =A0 PLEASE SEE/USE net/fping+ipv= 6 INSTEAD =A0 =A0 =A0 =A0 =A0 =A0 ***" > =A0@${ECHO_MSG} "*** =A0 =A0THESE PORTS CAN CO-EXIST TOGETHER AND BOTH BE= INSTALLED =A0 =A0***" > =A0@${ECHO_MSG} "********************************************************= *************" > =A0@sleep 10 > .endif > I would suggest the following changes for net/fping: - remove the ipv6 category from net/fping, since it is ipv4 only. Change comment to: COMMENT=3D Quickly ping N hosts w/o flooding the network - IPv4 Only versio= n - Remove this define from the ports Makefile: .if defined(WITH_IPV6) # IPv6 not enabled by default, as it does not work together with IPv4. CFLAGS+=3D -DIPV6 .endif I also noticed that the net/fping includes a source address patch (net/fping/files/patch-sourceaddr) that is missing in the net/fping+ipv6 port. The patch seems to support both ipv4 or ipv6 depending on if IPV6 is defined. Scot