From owner-cvs-src@FreeBSD.ORG Wed Jun 2 11:15:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A2AD16A4CE; Wed, 2 Jun 2004 11:15:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 234DC43D4C; Wed, 2 Jun 2004 11:15:49 -0700 (PDT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i52IFmP0026427; Wed, 2 Jun 2004 11:15:48 -0700 (PDT) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i52IFmKu026426; Wed, 2 Jun 2004 11:15:48 -0700 (PDT) (envelope-from scottl) Message-Id: <200406021815.i52IFmKu026426@repoman.freebsd.org> From: Scott Long Date: Wed, 2 Jun 2004 11:15:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 18:15:49 -0000 scottl 2004/06/02 11:15:48 PDT FreeBSD src repository Modified files: sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h Log: Collapse sync fib locking into normal i/o locking. The former didn't protect the registers so it was trivially possible for a sync command and i/o command to fight each other and confuse the controller. Make the sync fib alloc/release functions inline and remove the somewhat worthless AAC_SYNC_LOCK_FORCE flag. Thanks to Adil Katchi for helping me to track this down in RELENG_4. Revision Changes Path 1.94 +5 -38 src/sys/dev/aac/aac.c 1.16 +2 -2 src/sys/dev/aac/aac_cam.c 1.39 +2 -1 src/sys/dev/aac/aac_disk.c 1.43 +21 -7 src/sys/dev/aac/aacvar.h