From owner-freebsd-gnome@FreeBSD.ORG Sat Feb 4 05:41:18 2012 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13B241065670 for ; Sat, 4 Feb 2012 05:41:18 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from sunpoet.net (sunpoet.net [220.133.12.240]) by mx1.freebsd.org (Postfix) with ESMTP id A0DD08FC0A for ; Sat, 4 Feb 2012 05:41:17 +0000 (UTC) Received: by sunpoet.net (Postfix, from userid 1000) id 6C73F19DC; Sat, 4 Feb 2012 13:22:20 +0800 (CST) To: FreeBSD-gnats-submit@freebsd.org From: Sunpoet Po-Chuan Hsieh X-send-pr-version: 3.113 X-GNATS-Notify: Message-Id: <20120204052220.6C73F19DC@sunpoet.net> Date: Sat, 4 Feb 2012 13:22:20 +0800 (CST) Cc: gnome@FreeBSD.org Subject: [PATCH] devel/gamin: add option for libinotify to fix build when it's already installed X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 05:41:18 -0000 >Submitter-Id: current-users >Originator: Sunpoet Po-Chuan Hsieh >Organization: The FreeBSD Project >Confidential: no >Synopsis: [PATCH] devel/gamin: add option for libinotify to fix build when it's already installed >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: FreeBSD 9.0-STABLE amd64 >Environment: System: FreeBSD bonjour.sunpoet.net 9.0-STABLE FreeBSD 9.0-STABLE #0: Sun Jan 29 23:36:49 CST 2012 >Description: - Add an option for libinotify Port maintainer (gnome@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: gamin fails to build when libinotify is installed % cd /usr/ports/devel/libinotify % make install % cd /usr/ports/devel/gamin % make build ... gmake[3]: Entering directory `/usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server' /bin/sh /usr/local/bin/libtool --tag=CC --mode=link cc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wsign-compare -Wno-sign-compare -g -O2 -pipe -march=core2 -fno-strict-aliasing -L/usr/local/lib -pthread -o gam_server gam_subscription.o gam_listener.o gam_server.o gam_node.o gam_tree.o gam_poll_basic.o gam_poll_generic.o gam_pidname.o gam_channel.o gam_connection.o gam_debugging.o gam_excludes.o gam_fs.o gam_conf.o gam_eq.o gam_inotify.o inotify-helper.o inotify-kernel.o inotify-missing.o inotify-path.o inotify-sub.o inotify-diag.o gam_kqueue.o ../lib/libgamin_shared.a -L/usr/local/lib -lglib-2.0 libtool: link: cc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wsign-compare -Wno-sign-compare -g -O2 -pipe -march=core2 -fno-strict-aliasing -pthread -o gam_server gam_subscription.o gam_listener.o gam_server.o gam_node.o gam_tree.o gam_poll_basic.o gam_poll_generic.o gam_pidname.o gam_channel.o gam_connection.o gam_debugging.o gam_excludes.o gam_fs.o gam_conf.o gam_eq.o gam_inotify.o inotify-helper.o inotify-kernel.o inotify-missing.o inotify-path.o inotify-sub.o inotify-diag.o gam_kqueue.o -L/usr/local/lib ../lib/libgamin_shared.a /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libiconv.so /usr/local/lib/libpcre.so -pthread -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/local/lib inotify-kernel.o: In function `ik_ignore': /usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server/inotify-kernel.c:297: undefined reference to `inotify_rm_watch' inotify-kernel.o: In function `ik_watch': /usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server/inotify-kernel.c:277: undefined reference to `inotify_add_watch' inotify-kernel.o: In function `ik_startup': /usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server/inotify-kernel.c:188: undefined reference to `inotify_init' gmake[3]: *** [gam_server] Error 1 gmake[3]: Leaving directory `/usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10/server' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/ports/works/usr/ports/devel/gamin/work/gamin-0.1.10' gmake: *** [all] Error 2 *** Error code 1 >Fix: --- gamin-0.1.10_4.patch begins here --- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/devel/gamin/Makefile,v retrieving revision 1.41 diff -u -u -r1.41 Makefile --- Makefile 23 Sep 2011 22:21:56 -0000 1.41 +++ Makefile 4 Feb 2012 05:20:12 -0000 @@ -30,7 +30,8 @@ GNU_CONFIGURE= yes .if !defined(GAMIN_SLAVE) -OPTIONS= GAM_POLLER "Use gamin's poller instead of kqueue's" off +OPTIONS= GAM_POLLER "Use gamin's poller instead of kqueue's" off \ + LIBINOTIFY "Build libinotify support" off .endif .include @@ -39,6 +40,14 @@ .if defined(WITH_GAM_POLLER) CPPFLAGS+= -DUSE_GAMIN_POLLER=1 .endif + +.if defined(WITH_LIBINOTIFY) +CONFIGURE_ARGS+=--enable-inotify +LDFLAGS+= -L${LOCALBASE}/lib -linotify +LIB_DEPENDS+= inotify:${PORTSDIR}/devel/libinotify +.else +CONFIGURE_ARGS+=--disable-inotify +.endif .endif post-patch: --- gamin-0.1.10_4.patch ends here ---