Date: Mon, 8 Mar 2010 16:11:42 -0500 From: John Baldwin <jhb@freebsd.org> To: "Jung-uk Kim" <jkim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204877 - head/sys/modules/acpi/acpi Message-ID: <201003081611.42854.jhb@freebsd.org> In-Reply-To: <201003081940.o28JeVG1088074@svn.freebsd.org> References: <201003081940.o28JeVG1088074@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 08 March 2010 2:40:31 pm Jung-uk Kim wrote: > Author: jkim > Date: Mon Mar 8 19:40:31 2010 > New Revision: 204877 > URL: http://svn.freebsd.org/changeset/base/204877 > > Log: > Enable ACPI module build on amd64. Although we strongly recommend building > it into kernel, there is no need to prevent it from building at all. (Oops, ignore previous spurious reply). Please revert this. The MADT parser on amd64 is slightly different from i386 and will not work when acpi is loaded as a module. If anything, I would prefer we make acpi not be a module on i386. There are several things that would be far less invasive to implement via #ifdef DEV_ACPI than by defining runtime kobj interfaces to the ACPI driver. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003081611.42854.jhb>