From owner-svn-src-vendor@freebsd.org  Tue Jul 14 11:14:57 2015
Return-Path: <owner-svn-src-vendor@freebsd.org>
Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DAC599CFCA;
 Tue, 14 Jul 2015 11:14:57 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 49ACFD1D;
 Tue, 14 Jul 2015 11:14:57 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1ZEyAp-000Mvi-9j; Tue, 14 Jul 2015 14:14:55 +0300
Date: Tue, 14 Jul 2015 14:14:55 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Andriy Gapon <avg@FreeBSD.org>
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-vendor@FreeBSD.org
Subject: Re: svn commit: r285025 - vendor-sys/illumos/dist/uts/common/fs/zfs
Message-ID: <20150714111455.GH44094@zxy.spb.ru>
References: <201507021101.t62B1SlK075159@repo.freebsd.org>
 <20150712135246.GA43740@zxy.spb.ru> <55A4E40C.3090608@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A4E40C.3090608@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: svn-src-vendor@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the vendor work area tree
 <svn-src-vendor.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-vendor>,
 <mailto:svn-src-vendor-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-vendor/>
List-Post: <mailto:svn-src-vendor@freebsd.org>
List-Help: <mailto:svn-src-vendor-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-vendor>,
 <mailto:svn-src-vendor-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 11:14:57 -0000

On Tue, Jul 14, 2015 at 01:27:24PM +0300, Andriy Gapon wrote:

> On 12/07/2015 16:52, Slawa Olhovchenkov wrote:
> > On Thu, Jul 02, 2015 at 11:01:28AM +0000, Andriy Gapon wrote:
> > 
> >> Author: avg
> >> Date: Thu Jul  2 11:01:27 2015
> >> New Revision: 285025
> >> URL: https://svnweb.freebsd.org/changeset/base/285025
> >>
> >> Log:
> >>   6033 arc_adjust() should search MFU lists for oldest buffer when adjusting MFU size
> >>   
> >>   illumos/illumos-gate@31c46cf23cd1cf4d66390a983dc5072d7d299ba2
> >>   
> >>   https://www.illumos.org/issues/6033
> >>     When we're looking for the list containing oldest buffer we never actually look
> >>     at the MFU lists even when we try to evict from MFU.
> >>     looks like a copy paste error, the fix is here:
> >>   
> >>   Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
> >>   Reviewed by: Xin Li <delphij@delphij.net>
> >>   Reviewed by: Prakash Surya <me@prakashsurya.com>
> >>   Approved by: Matthew Ahrens <mahrens@delphix.com>
> >>   Author: Alek Pinchuk <alek@nexenta.com>
> >>   Obtained from:	illumos
> >>
> >> Modified:
> >>   vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c
> >>
> > 
> > Can you see also at arc_init:4297?
> > I see double init arc_mfu_ghost->arcs_lists[i] and no init arc_anon.
> > This is correct?
> > 
> 
> There is no double initialization if you look harder, one initialization is for
> data and the other is for metadata.

4295: list_create(&arc_mfu_ghost->arcs_lists[i], sizeof (arc_buf_hdr_t), offsetof(arc_buf_hdr_t, b_arc_node));
4297: list_create(&arc_mfu_ghost->arcs_lists[i], sizeof (arc_buf_hdr_t), offsetof(arc_buf_hdr_t, b_arc_node));

I see two absolutly identical initialization

> Buffers in arc_anon state are not placed on a list.

This is correct? Or list initialization of arc_anon is missing?