Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Sep 2019 21:18:48 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r511364 - head/x11-wm/ede
Message-ID:  <201909062118.x86LImPa027953@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans (src committer)
Date: Fri Sep  6 21:18:48 2019
New Revision: 511364
URL: https://svnweb.freebsd.org/changeset/ports/511364

Log:
  x11-wm/ede: Add sed=gsed
  
  Two problems lie in ${EDELIB_WRKSRC}/sslib/gen-c-string.sh sed usage:
  
  - \s is a GNU extension, this is trivially replaced with [[:space:]],
    HOWEVER:
  - The next expression uses \t and expects a tab, but this will not happen
    with our sed.
  
  \s was caught by the patch in bug #229925 that forbids escaping ordinary
  characters that have no extra meaning to lessen the stress of later adding
  special behavior to some of these escape sequences. \t, however, will just
  silently do the wrong thing.
  
  Switch this over to gsed for now; a pass will be done later to check out
  every port with BUILD_DEPENDS containing gsed to evaluate whether we're
  ready for them to use base sed or not.
  
  QA:
   * portlint: OK (minor warnings that should be addressed separately)
   * testport: OK (poudriere: 13.0-CURRENT and 12.0-RELEASE, amd64)
   * diffoscope: OK (only minor metadata changes to package)
  
  PR:		240312
  Approved by:	koobs (ports)

Modified:
  head/x11-wm/ede/Makefile

Modified: head/x11-wm/ede/Makefile
==============================================================================
--- head/x11-wm/ede/Makefile	Fri Sep  6 21:10:41 2019	(r511363)
+++ head/x11-wm/ede/Makefile	Fri Sep  6 21:18:48 2019	(r511364)
@@ -19,6 +19,7 @@ LICENSE_FILE_GPLv2+ =	${WRKSRC}/COPYING
 LICENSE_FILE_LGPL20+ =	${EDELIB_WRKSRC}/COPYING
 
 BUILD_DEPENDS=	doxygen:devel/doxygen \
+		gsed:textproc/gsed \
 		jam:devel/jam
 LIB_DEPENDS=	libdbus-1.so:devel/dbus \
 		libcurl.so:ftp/curl \
@@ -27,6 +28,8 @@ LIB_DEPENDS=	libdbus-1.so:devel/dbus \
 
 USES=		fam gettext iconv:translit localbase:ldflags pathfix \
 		pkgconfig python:2.7 shared-mime-info shebangfix
+
+BINARY_ALIAS=	sed=${LOCALBASE}/bin/gsed
 SHEBANG_FILES=	doc/asciidoc/asciidoc.py
 USE_XORG=	xcomposite xft xinerama xkbfile xpm xrandr
 USE_CSTD=	gnu89



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909062118.x86LImPa027953>