From owner-freebsd-sparc64@FreeBSD.ORG Sat Jan 5 01:52:45 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8108AD37; Sat, 5 Jan 2013 01:52:45 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id DD653290; Sat, 5 Jan 2013 01:52:44 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.5/8.14.5/ALCHEMY.FRANKEN.DE) with ESMTP id r051qgKg038852; Sat, 5 Jan 2013 02:52:43 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.5/8.14.5/Submit) id r051qg7I038851; Sat, 5 Jan 2013 02:52:42 +0100 (CET) (envelope-from marius) Date: Sat, 5 Jan 2013 02:52:42 +0100 From: Marius Strobl To: Kurt Lidl , mav@freebsd.org Subject: Re: smartmontools panics 9.1-RELEASE on sunfire 240 Message-ID: <20130105015242.GB26039@alchemy.franken.de> References: <20130104051914.GA22613@pix.net> <20130104235336.GB37999@alchemy.franken.de> <20130105013224.GA31361@pix.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130105013224.GA31361@pix.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-sparc64@freebsd.org X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2013 01:52:45 -0000 On Fri, Jan 04, 2013 at 08:32:24PM -0500, Kurt Lidl wrote: > On Sat, Jan 05, 2013 at 12:53:36AM +0100, Marius Strobl wrote: > > Uhm, probably an userland buffer which isn't even 16-bit aligned. > > If that's the cause, the attached patch hopefully should at least > > prevent the panic. If it does, smartmontools still need to be fixed > > though. > > You patch prevents the panic from happening. > When I try to start smartd now, it reports: > > root@host-98: /usr/local/etc/rc.d/smartd onestart > Starting smartd. > smartd: cam_send_ccb: Invalid argument > /usr/local/etc/rc.d/smartd: WARNING: failed to start smartd > > I had updated the kernel on the machine to 9-STABLE, and > verified that without this patch, the crash still happened with > a 9-STABLE kernel, in addition to 9.1-RELEASE kernel. > > My kernel now identifies itself as: > FreeBSD 9.1-STABLE (GENERIC) #1 r245044:245048M: Fri Jan 4 20:19:50 EST 2013 > > -Kurt > > > Index: cam_periph.c > > =================================================================== > > --- cam_periph.c (revision 245046) > > +++ cam_periph.c (working copy) > > @@ -744,6 +744,9 @@ cam_periph_mapmem(union ccb *ccb, struct cam_perip > > if ((ccb->ccb_h.flags & CAM_DIR_MASK) == CAM_DIR_NONE) > > return(0); > > > > + if ((uintptr_t)ccb->ataio.data_ptr % sizeof(uint16_t) != 0) > > + return (EINVAL); > > + > > data_ptrs[0] = &ccb->ataio.data_ptr; > > lengths[0] = ccb->ataio.dxfer_len; > > dirs[0] = ccb->ccb_h.flags & CAM_DIR_MASK; > Alexander, are you okay with this approach or do you have a better idea how to handle this? In any case, it doesn't seem to make sense to teach the kernel how to cope with arbitrarily aligned buffers for ATA. Marius