From owner-svn-src-head@freebsd.org Mon Oct 30 15:57:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAB19E6063F; Mon, 30 Oct 2017 15:57:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB4F567ED6; Mon, 30 Oct 2017 15:57:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 0EAAF10C2D; Mon, 30 Oct 2017 15:57:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 0D86B9C4C; Mon, 30 Oct 2017 15:57:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Qr7z0WG6fZPL; Mon, 30 Oct 2017 15:57:36 +0000 (UTC) Subject: Re: svn commit: r322951 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 499CB9C47 To: "Ngie Cooper (yaneurabeya)" Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201708271615.v7RGFcKs033967@repo.freebsd.org> From: Bryan Drewery Organization: FreeBSD Message-ID: <34af7231-29ff-5ebe-44d1-0a7ae0dea235@FreeBSD.org> Date: Mon, 30 Oct 2017 08:57:10 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6X0UANm7l0OUS0U2mC2ftqR4H2e2FPehs" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:57:41 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6X0UANm7l0OUS0U2mC2ftqR4H2e2FPehs Content-Type: multipart/mixed; boundary="XrhXVkibhNwKBAIQLLAal3wFKaJdAIGoK"; protected-headers="v1" From: Bryan Drewery To: "Ngie Cooper (yaneurabeya)" Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <34af7231-29ff-5ebe-44d1-0a7ae0dea235@FreeBSD.org> Subject: Re: svn commit: r322951 - head References: <201708271615.v7RGFcKs033967@repo.freebsd.org> In-Reply-To: --XrhXVkibhNwKBAIQLLAal3wFKaJdAIGoK Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/30/17 1:44 AM, Ngie Cooper (yaneurabeya) wrote: >=20 >> On Oct 25, 2017, at 13:34, Bryan Drewery wrote:= >=20 > =E2=80=A6 >=20 >> I don't understand what you're saying here. If I build with MK_TCSH=3D= yes >> and the host does not have tcsh, a failure occurs AFTER or BEFORE this= >> change? >> Neither case makes sense to me. >> What is the failure? >> >> The change here is to build-tools which just calls 'make build-tools' = in >> bin/csh which just builds 'gethost'. >=20 > Yes. The relnotes concerns I mentioned are bogus. >=20 > Yeah, a ~400 line C file isn=E2=80=99t that bad, I agree. >=20 > I really don=E2=80=99t care about arguing this or debating it. Yes, you= =E2=80=99re right on all counts. It=E2=80=99s a micro optimization. I wasn't trying to argue or anything, just trying to understand if there was a big issue here. Thanks! >=20 --=20 Regards, Bryan Drewery --XrhXVkibhNwKBAIQLLAal3wFKaJdAIGoK-- --6X0UANm7l0OUS0U2mC2ftqR4H2e2FPehs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEzBAEBCgAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAln3S9gACgkQNddxu25G l89uqQgAnZsdszqHGmfjv7IiN3IbeNB0QYtfbs3hPhKXmtxvaM0dc1WvX0Ch3FtN 0ECaKc/Z8dzcRX/Q6wZ/SK2SE++oRd6TEVqgQeeZxiRkUt3agN242eKBfJvAvPlM jfqgxd8IG7NfAtQFCy8+KwHEeF2Th2seIxwatSTBSSmRPd3HtdC/NHmagM9nb7bU +WlJ9Nj/8lEkDE5SguU8fi+beEmzg0WHlDmPPDH818T2OFMPJu0TSgHs1ApKnhfP KulZvWlQTQPR9VHgtqbJeL17egNY4RFSEsyDqm7BVC9znNTOWWbkTbyKMVrc2Czt NTub5X8F2twtX7xD6kbpQ+7urjUD2Q== =V/3U -----END PGP SIGNATURE----- --6X0UANm7l0OUS0U2mC2ftqR4H2e2FPehs--