From owner-cvs-usrsbin  Fri May  9 22:40:13 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id WAA20171
          for cvs-usrsbin-outgoing; Fri, 9 May 1997 22:40:13 -0700 (PDT)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA20165;
          Fri, 9 May 1997 22:40:05 -0700 (PDT)
Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id GAA13589;
	Sat, 10 May 1997 06:39:47 +0100 (BST)
Message-Id: <199705100539.GAA13589@awfulhak.demon.co.uk>
X-Mailer: exmh version 1.6.9 8/22/96
To: Bruce Evans <bde@zeta.org.au>
cc: brian@awfulhak.org, ache@nagual.pp.ru, brian@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG,
        cvs-usrsbin@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp timer.c 
In-reply-to: Your message of "Sat, 10 May 1997 15:24:28 +1000."
             <199705100524.PAA06538@godzilla.zeta.org.au> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 10 May 1997 06:39:47 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> >> Actually it is, read the kernel source :-).  The kernel checks the interval
> >> even when it doesn't use it and fails without doing anything if the interval
> >> is garbage (tv_sec < 0 || tv_sec > 10^8 || tv_usec < 0 || tv_usec >= 10^6).
> >
> >Should I fix kern/kern_time.c then ?
> 
> No, it's not incorrect.  It does almost exactly what the ERRORS section in
> the man page says: it returns EINVAL if "_a_ value parameter specified a
> time that was too large to be handled".  The man page is just sloppy in
> not mentioning that it returns EINVAL if a value parameter was invalid.

Ouch.  Too late.  Should I roll it back out ?  (I'll wait for a
bit longer before sticking my feet in this time).

> Bruce

-- 
Brian <brian@awfulhak.org>, <brian@freebsd.org>
      <http://www.awfulhak.org>
Don't _EVER_ lose your sense of humour....