From owner-svn-src-user@FreeBSD.ORG  Tue Oct 23 22:15:48 2012
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id CFBD1B91;
 Tue, 23 Oct 2012 22:15:48 +0000 (UTC)
 (envelope-from mdf356@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
 [209.85.160.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 87F1D8FC12;
 Tue, 23 Oct 2012 22:15:48 +0000 (UTC)
Received: by mail-pb0-f54.google.com with SMTP id rp8so816645pbb.13
 for <multiple recipients>; Tue, 23 Oct 2012 15:15:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=3FuBzZmpRr52OKxljOi4FRQfqHTRj10PfxPfZnyskj8=;
 b=LF3oiiLmCdat5uxXANTJjILSR833IG/aqLT35P3b2L0YkySN2N5wZ7Qi5Un0BuwHRq
 4wXUO5J6tgUocDLAoGSAkVXpfZHQMNg3pP0qNmH+Op/Sl/FQAgyANhYsMXMcgcwQEwIm
 isxJSroUeVRcOFd3PbjtnGr7MancoOWETMx7C/7mcHDeObDcyDnb/9tmIDqeGOPZ+03s
 7YMZ2g5DZ5dZ7wsiMva4N7Jn3D4lhqiumtAHt+b0wxDjLUd4p+C8qfa/XoMnxeU+/WvH
 /laQqtnddq2YCiwDtxbMwgb+BQz41R+io39eqKhWtwznLKdoN9FbQFIa36T3RtzuCWSU
 fayQ==
MIME-Version: 1.0
Received: by 10.68.189.138 with SMTP id gi10mr43799122pbc.165.1351030548203;
 Tue, 23 Oct 2012 15:15:48 -0700 (PDT)
Sender: mdf356@gmail.com
Received: by 10.68.223.105 with HTTP; Tue, 23 Oct 2012 15:15:48 -0700 (PDT)
In-Reply-To: <5086AC94.2090700@freebsd.org>
References: <201210221418.q9MEINkr026751@svn.freebsd.org>
 <20121023032743.K2804@besplex.bde.org>
 <508664C7.3080206@freebsd.org> <201210230853.56549.jhb@freebsd.org>
 <5086AC94.2090700@freebsd.org>
Date: Tue, 23 Oct 2012 15:15:48 -0700
X-Google-Sender-Auth: 3dcGJSeN8zO7tfD8yhEZqCj8alw
Message-ID: <CAMBSHm-NYtqL71_5zvKj5RNO+-ryc6av760eSwBncgP=1d7+mQ@mail.gmail.com>
Subject: Re: svn commit: r241889 - in user/andre/tcp_workqueue/sys: arm/arm
 cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/dtrace
 cddl/contrib/opensolaris/uts/common/fs/zfs ddb dev/acpica dev/...
From: mdf@FreeBSD.org
To: Andre Oppermann <andre@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>,
 John Baldwin <jhb@freebsd.org>, svn-src-user@freebsd.org
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 22:15:48 -0000

On Tue, Oct 23, 2012 at 7:41 AM, Andre Oppermann <andre@freebsd.org> wrote:
> Struct mtx and MTX_SYSINIT always occur as pair next to each other.

That doesn't matter.  Language basics like variable definitions should
not be obscured by macros.  It either takes longer to figure out what
a variable is (because one needs to look up the definition of the
macro) or makes it almost impossible (because now e.g. cscope doesn't
know this is a variable definition.

Thanks,
matthew