From owner-svn-ports-all@FreeBSD.ORG Fri May 9 19:38:26 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63213B2F for ; Fri, 9 May 2014 19:38:26 +0000 (UTC) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DDF56B4E for ; Fri, 9 May 2014 19:38:25 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id ec20so205090lab.26 for ; Fri, 09 May 2014 12:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=h26iyCVhScL2CFjVUara2j8KwYZnm6bSPuEZoNq1vJ8=; b=I5tjwmG0RADD8j+w6pH7MWPJMUsb1KWd8wgUWc1UpPPACGEHUwJKPvoz+HWJ1zjMmB lx+Y9ImCpryH8NOsUOgW922fjXh5hggIBuVo7XbjGgKuhUtEIuHTsSWPAgRElTKhJrbS E5NJRIFjpEsAoY3eiszo0horyLqcWlPLaZdMmiJkDP9OYvenVIy6JntRWwHsTYHEmOCs rCD2/y1YnGM80dN9gSZZUj0PewLnR2EJHkc9iADphuks6JjnXafg5OELAjS5xSbDrrnQ z2YGEymwkr/h2tPxtkR7xfwFVSmKTguwxMQLX9BEyjITDvztXvGqcgKetcFjldKbxjej SWig== X-Gm-Message-State: ALoCoQlrg7LYdEXYZ0iMoJBbqSm3fivm9pXBlqJpXoZNXPc+rDytIjkJ0YyW+0JlOm7091gMI2pc X-Received: by 10.152.36.134 with SMTP id q6mr616398laj.29.1399664303204; Fri, 09 May 2014 12:38:23 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.151.238 with HTTP; Fri, 9 May 2014 12:38:03 -0700 (PDT) In-Reply-To: <20140509181117.335833e7@kalimero.tijl.coosemans.org> References: <201405091526.s49FQ5HW013837@svn.freebsd.org> <20140509181117.335833e7@kalimero.tijl.coosemans.org> From: Sunpoet Po-Chuan Hsieh Date: Sat, 10 May 2014 03:38:03 +0800 X-Google-Sender-Auth: 2X73IKCz4Gs6_muWmQj8wlZH248 Message-ID: Subject: Re: svn commit: r353466 - head/astro/cfitsio To: Tijl Coosemans , Raphael Kubo da Costa Content-Type: text/plain; charset=UTF-8 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 19:38:26 -0000 On Sat, May 10, 2014 at 12:11 AM, Tijl Coosemans wrote: > On Fri, 9 May 2014 15:26:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote: >> Author: sunpoet >> Date: Fri May 9 15:26:05 2014 >> New Revision: 353466 >> URL: http://svnweb.freebsd.org/changeset/ports/353466 >> QAT: https://qat.redports.org/buildarchive/r353466/ >> >> Log: >> - Pass -lz to libdata/pkgconfig/cfitsio.pc >> - Bump PORTREVISION for package change >> >> PR: ports/189487 >> Submitted by: rakuco > > Can you patch cfitsio.pc to move @LIBS@ to the Libs.private field? > Other ports run 'pkg-config --libs cfitsio' to know what libraries > to link to and the output of that includes -lz now. > "-L${LIBDIR}" can be removed I think. All compilers should search > it by default. Hi, I prepared a new patch [1] which reverted r353466 and patched cfitsio.pc. It's OK in my tinderbox. Would you please check if it works for you? Thanks! [1] https://people.freebsd.org/~sunpoet/cfitsio.patch Regards, sunpoet