From owner-cvs-src-old@FreeBSD.ORG Fri Sep 10 23:49:46 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E57D106564A for ; Fri, 10 Sep 2010 23:49:46 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8C9E58FC15 for ; Fri, 10 Sep 2010 23:49:46 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o8ANnkrN057539 for ; Fri, 10 Sep 2010 23:49:46 GMT (envelope-from rmacklem@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o8ANnkJj057538 for cvs-src-old@freebsd.org; Fri, 10 Sep 2010 23:49:46 GMT (envelope-from rmacklem@repoman.freebsd.org) Message-Id: <201009102349.o8ANnkJj057538@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to rmacklem@repoman.freebsd.org using -f From: Rick Macklem Date: Fri, 10 Sep 2010 23:49:33 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/nfsserver nfs_nfsdstate.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 23:49:46 -0000 rmacklem 2010-09-10 23:49:33 UTC FreeBSD src repository Modified files: sys/fs/nfsserver nfs_nfsdstate.c Log: SVN rev 212443 on 2010-09-10 23:49:33Z by rmacklem This patch applies one of the two fixes suggested by zack.kirsch at isilon.com for a race between nfsrv_freeopen() and nfsrv_getlockfile() in the experimental NFS server that he found during testing. Although nfsrv_freeopen() holds a sleep lock on the lock file structure when called with cansleep != 0, nfsrv_getlockfile() could still search the list, once it acquired the NFSLOCKSTATE() mutex. I believe that acquiring the mutex in nfsrv_freeopen() fixes the race. MFC after: 2 weeks Revision Changes Path 1.21 +6 -1 src/sys/fs/nfsserver/nfs_nfsdstate.c