From nobody Tue Jan 13 15:37:11 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drCzs6N6lz6NJy9 for ; Tue, 13 Jan 2026 15:37:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drCzs3D9Pz3CgP for ; Tue, 13 Jan 2026 15:37:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-81dbc0a99d2so2089414b3a.1 for ; Tue, 13 Jan 2026 07:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1768318643; x=1768923443; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WRzFjmj/ASKcNxcJXbFp+EvteGfsNpLLoU//kd0o9FA=; b=SdFwOEzJ/0fQTps91XopKTD1O6BmfFDEWR6ls6uPPqqqXm27GWlvMEK7sWs27svaXs GqCWs72c7TRhuV97HRloPLwiEMpVtFoNMZ3alhpw2wqr7uynsP9MgBNBDI4pFOtm/5Ys 3hPSEUMQhwuvT0amCvbHV1D/ymbJjNmJuapkPgoWLDcFFTlHmYSms0ksnmFPPy0xwvbL iyxyd9UykdsLOv3vsUV0nnfo+7D8/d2ryGffpfq8/n3Db8Duc90h20GGkyTmCYMAgjVJ NnwjsBp39KFcuOHq12pY1awP0D/7cUHkWgnT81B2wApF9F8GzWfdDIMxnpmsSfncsMdI q3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768318643; x=1768923443; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WRzFjmj/ASKcNxcJXbFp+EvteGfsNpLLoU//kd0o9FA=; b=JRousxwGeGnO0byvJKXZKa6N1VTc354wRUIcItCqAm4f6/xLAnJD85DLrJ6uha0naO /gVkvzzh+T7h5l7eciyX31fT10zP4HfTDSl5a1zowE1w1pH0/0d3TbF/DkXvGaidl0BV L760ivBFtZGvQNtfBPwSZpGEZCYBqe8IuF2NbH8d/Z4dxFuf1jpriVkIBei2OIFLvuHm sxOV6aDnOEvlNdT4iVycCB7Fchuj0toTm3yRfZNVVqNzd9M5rRBiHkcTy0Pyp6iCcvSH f+ULTX3yV7lieXSl+gSAYNFBkkNnDgAUWS3FsDehZwFUjrboVnAr4kk5Pw9Zst5vmO+C 9hSQ== X-Forwarded-Encrypted: i=1; AJvYcCV6ZFSB7oBevp4rQBfpD/C8Obbcm8tAXdpOaBeAXZ8zODnCIppe4VajeU2JdrM6l8cKxgTFJJO/RJJX9vutVYnI6YvbWw==@freebsd.org X-Gm-Message-State: AOJu0YzeTAsD+ZrOO7w/ln4PtiV5IcWwsNyacvCS/i2f49iIR1loIa3t 6IJwXRGP4MLn93KrvW3qoeqSVfjitky4cQ2NUOVnJSzLDax1fjhiwFKjYvg5c/kDA0CRkuJOwxl 7KGCxiJkdAlofEtmnc6vUwRVEClQQ6Sb8tXgEtiKgcQ== X-Gm-Gg: AY/fxX7ftVmpsXgBQb8ShCm9vlFT1CWn+uMQ3rqMEYR5nGmMVf+VmWjnS26pu7lLjmn vziuv0EexIbaUwqv+/TiIOj/R/M6B+7mahtp5WkPc5gpCbx7XNlPa8oLaqk/MoKkwFebvTLOrvf ED3hOIs6dUZXB1AX+7sVc89f+F+QJtbzS8KWkHZl1A+ztPgxrjhWIcaC5XXdRgFR7l2hN7sYWch 3QHEud6ondxkdspLCkKDai9q+dEo32Ene/u2UjXT5imLmeisNQwhvt0qk7MOxj10ga+bio= X-Google-Smtp-Source: AGHT+IEC/ZQ/D2FX1M1gztx0aI2oET6jawhuGaNasKTpBe8LBdvOha5bsUgvvyQJyFt+um82qi3FOQvkyLUvtLFxA8c= X-Received: by 2002:a05:6a20:7d9d:b0:350:b8e:f9a9 with SMTP id adf61e73a8af0-3898f9b9aecmr18893130637.42.1768318642712; Tue, 13 Jan 2026 07:37:22 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> In-Reply-To: <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> From: Warner Losh Date: Tue, 13 Jan 2026 08:37:11 -0700 X-Gm-Features: AZwV_Qi80dytxFeahXZZBfvs9ovSNLjoPJWLRumRIsfqbqGhz2Y3fT-CCJydVxY Message-ID: Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests To: John Baldwin Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000008c8294064846c42d" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4drCzs3D9Pz3CgP --0000000000008c8294064846c42d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2026 at 7:56=E2=80=AFAM John Baldwin wrot= e: > On 1/12/26 02:37, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001d94974a081e5fd58c4f= 3994429cb > > > > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb > > Author: Warner Losh > > AuthorDate: 2026-01-10 16:20:20 +0000 > > Commit: Warner Losh > > CommitDate: 2026-01-12 07:18:11 +0000 > > > > github: Add more context to pull requests > > > > Add code to fetch and decode CODEOWNERS and automatically @ people > in > > the review. > > > > Create a new file, .github/path-rules.txt that has a set of paths = to > > match and specific warnings about that part of the tree. We'll use > this > > to try to wave off pull requests in certain areas of the tree, as > well > > as remind people when contrib is involved, etc. > > > > Sponsored by: Netflix > > --- > > .github/path-rules.txt | 10 ++++ > > .github/workflows/checklist.yml | 106 > ++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 106 insertions(+), 10 deletions(-) > > > > diff --git a/.github/path-rules.txt b/.github/path-rules.txt > > new file mode 100644 > > index 000000000000..297cfe8def35 > > --- /dev/null > > +++ b/.github/path-rules.txt > > @@ -0,0 +1,10 @@ > > +# > > +# Format the similar to CODEOWNERS: Each line has a path, whitespace > and a > > +# message for contributors. > > +# > > +sys/contrib/device-tree :caution: No changes should be made here > by pull request > > +# Catch all > > +contrib :warning: Contributed software usually managed by > vendor branch > > +crypto :warning: Contributed crypto software usually > managed by vendor branch > > +sys/contrib :warning: Contributed software usually managed by vendor > branch > > +sys/crypto :warning: Contributed crypto software usually managed by > vendor branch > > sys/crypto isn't really the same. We store the generated OpenSSL assembl= y > files there > for use by ossl(4), but most of sys/crypto is not vendored (e.g. ccp, the > non-assembly ossl > bits, aesni are all just bespoke). > That's the beauty of this: We can have whatever we want here... These were placeholders until we had more nuanced things. I see things like openssh in crypto too, so many things are vendored there, in addition to the mire of inconsistency... First one wins (or did I take that out, if I did, I should put it back).... I'd also thought this might couple well with the 3rd party audit and we could generate some json from that to give upstream pointers, project contacts, etc around all that. But maybe just :caution: Cryptographic software requires special care that the project cannot give to pull requests. Warner --0000000000008c8294064846c42d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jan 13,= 2026 at 7:56=E2=80=AFAM John Baldwin <jhb@freebsd.org> wrote:
On 1/12/26 02:37, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001d94974a081e5fd58c4f3994429cb<= /a>
>
> commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2026-01-10 16:20:20 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2026-01-12 07:18:11 +0000
>
>=C2=A0 =C2=A0 =C2=A0 github: Add more context to pull requests
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Add code to fetch and decode CODEOWNERS and automa= tically @ people in
>=C2=A0 =C2=A0 =C2=A0 the review.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Create a new file, .github/path-rules.txt that has= a set of paths to
>=C2=A0 =C2=A0 =C2=A0 match and specific warnings about that part of the= tree. We'll use this
>=C2=A0 =C2=A0 =C2=A0 to try to wave off pull requests in certain areas = of the tree, as well
>=C2=A0 =C2=A0 =C2=A0 as remind people when contrib is involved, etc. >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix
> ---
>=C2=A0 =C2=A0.github/path-rules.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 ++++
>=C2=A0 =C2=A0.github/workflows/checklist.yml | 106 ++++++++++++++++++++= ++++++++++++++++----
>=C2=A0 =C2=A02 files changed, 106 insertions(+), 10 deletions(-)
>
> diff --git a/.github/path-rules.txt b/.github/path-rules.txt
> new file mode 100644
> index 000000000000..297cfe8def35
> --- /dev/null
> +++ b/.github/path-rules.txt
> @@ -0,0 +1,10 @@
> +#
> +# Format the similar to CODEOWNERS: Each line has a path, whitespace = and a
> +# message for contributors.
> +#
> +sys/contrib/device-tree=C2=A0 =C2=A0 =C2=A0 :caution: No changes shou= ld be made here by pull request
> +# Catch all
> +contrib=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :warning: Con= tributed software usually managed by vendor branch
> +crypto=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:warning= : Contributed crypto software usually managed by vendor branch
> +sys/contrib=C2=A0 :warning: Contributed software usually managed by v= endor branch
> +sys/crypto=C2=A0 =C2=A0:warning: Contributed crypto software usually = managed by vendor branch

sys/crypto isn't really the same.=C2=A0 We store the generated OpenSSL = assembly files there
for use by ossl(4), but most of sys/crypto is not vendored (e.g. ccp, the n= on-assembly ossl
bits, aesni are all just bespoke).


--0000000000008c8294064846c42d--