From owner-svn-src-head@freebsd.org Tue Mar 12 10:18:02 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DD79152999B; Tue, 12 Mar 2019 10:18:02 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E8E538762F; Tue, 12 Mar 2019 10:18:01 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id x2CAHxim063427; Tue, 12 Mar 2019 11:17:59 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id AE8023DC; Tue, 12 Mar 2019 11:17:58 +0100 (CET) Subject: Re: svn commit: r345057 - head/share/man/man7 To: Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201903120927.x2C9Rc1B017630@repo.freebsd.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <79a9c91f-72c2-ef18-e341-4ed471fb787c@omnilan.de> Date: Tue, 12 Mar 2019 11:17:58 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201903120927.x2C9Rc1B017630@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Tue, 12 Mar 2019 11:17:59 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: E8E538762F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.966,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 10:18:02 -0000 Am 12.03.2019 um 10:27 schrieb Mateusz Piotrowski: > Author: 0mp (ports committer) > Date: Tue Mar 12 09:27:37 2019 > New Revision: 345057 > URL: https://svnweb.freebsd.org/changeset/base/345057 > > Log: > ports.7: Add an example of how to use flavors > > At the moment the manual page is not documenting how to build > a flavored package. Let's start documenting flavors with > an example of a typical use case. > > Reported by: cem, dim > Reviewed by: bcr, cem, mat, matthew > Approved by: cem (src) > Differential Revision: https://reviews.freebsd.org/D19531 > > Modified: > head/share/man/man7/ports.7 > > Modified: head/share/man/man7/ports.7 > ============================================================================== > --- head/share/man/man7/ports.7 Tue Mar 12 09:24:58 2019 (r345056) > +++ head/share/man/man7/ports.7 Tue Mar 12 09:27:37 2019 (r345057) > @@ -25,7 +25,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd February 12, 2019 > +.Dd March 12, 2019 > .Dt PORTS 7 > .Os > .Sh NAME > @@ -587,7 +587,7 @@ The following command builds and installs Emacs. > .Ed > .It Sy Example 2\&: No Installing Dependencies with Xr pkg 8 > .Pp > -The following examples shows how to build and install a port without having to > +The following example shows how to build and install a port without having to > build its dependencies. > Instead, the dependencies are downloaded via > .Xr pkg 8 . > @@ -603,6 +603,16 @@ The drawback is that > .Xr pkg 8 > offers only packages built with the default set of > .Va OPTIONS . > +.It Sy Example 3\&: No Building a Non-Default Flavor of a Port > +.Pp > +The following command builds a non-default flavor of a port. > +(In this case > +.Pa devel/py-pip > +is going to be built with Python 3.7 support.) > +.Bd -literal -offset 2n > +.Li # Ic cd /usr/ports/devel/py-pip > +.Li # Ic env FLAVOR=py37 make build Since cem and dim seem to stumbled over the missing FLAVOR documentation, I see my main objection against current FLAVOR implementation confirmed:  Build stage must'nt silently chose a default FALVOR, but an OPTIONS-like dialog must inform the user and she _must_ choose one. FLAVOR is a severe regression for ports usage to all FreeBSD users imho. Users can't see if a port makes use of FLAVOR or not. User won't get informed that default FLAVOR is in use. Users can't see what FLAVORs are supported (and/or why, with what consequences...). Port/Package name relation gets lost (also for make(1) variables widley used in my scripts, which I still have to track down...). FLAVOR silently broke $WRKDIRPREFIX. If of any use, it's solely for maintainers, but at the cost of users.  The ports options framework is not really user friendly too, but does a basic job in guiding users.  FLAVOR does the opposite. There was nothing wrong with slave ports.  If maintainers have to spend a fraction more time on slave ports than on FLAVORized ports, it's worth every second, instead of distracting users. The more poudriere optimization the ports tree gets, the more distraction for users/admins/engineers/students comes along and FreeBSD loses one elementary strength of the project, imho. Instructing users to set an environment variable to a value, which they have to lookup from a Makefile, is a very poor usability design, imho. Hope this isn't the completely wrong place to point to ports stuff... Thanks, -harry