From owner-svn-ports-all@FreeBSD.ORG  Fri May  9 19:55:53 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 041B326D;
 Fri,  9 May 2014 19:55:53 +0000 (UTC)
Received: from mailrelay010.isp.belgacom.be (mailrelay010.isp.belgacom.be
 [195.238.6.177]) by mx1.freebsd.org (Postfix) with ESMTP id F263FCEA;
 Fri,  9 May 2014 19:55:51 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AmoGAHkxbVNR8aV7/2dsb2JhbABZFoJwT0vFYQGBGRd0giUBAQU6HCMQCxQECSUPKh4GE4hFAQjREBeOUgeEQAEDmUaBPZFGgzg7MA
Received: from 123.165-241-81.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([81.241.165.123])
 by relay.skynet.be with ESMTP; 09 May 2014 21:55:44 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s49JthMA054150;
 Fri, 9 May 2014 21:55:43 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Fri, 9 May 2014 21:55:42 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Subject: Re: svn commit: r353466 - head/astro/cfitsio
Message-ID: <20140509215542.2a706619@kalimero.tijl.coosemans.org>
In-Reply-To: <CAMHz58Rb6DL+RXjNUa583mg7sOSfK7zj1FDupRj1eG8V=FdRHg@mail.gmail.com>
References: <201405091526.s49FQ5HW013837@svn.freebsd.org>
 <20140509181117.335833e7@kalimero.tijl.coosemans.org>
 <CAMHz58Rb6DL+RXjNUa583mg7sOSfK7zj1FDupRj1eG8V=FdRHg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Raphael Kubo da Costa <rakuco@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 May 2014 19:55:53 -0000

On Sat, 10 May 2014 03:38:03 +0800 Sunpoet Po-Chuan Hsieh wrote:
> On Sat, May 10, 2014 at 12:11 AM, Tijl Coosemans <tijl@freebsd.org> wrote:
>> On Fri, 9 May 2014 15:26:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote:
>>> Author: sunpoet
>>> Date: Fri May  9 15:26:05 2014
>>> New Revision: 353466
>>> URL: http://svnweb.freebsd.org/changeset/ports/353466
>>> QAT: https://qat.redports.org/buildarchive/r353466/
>>>
>>> Log:
>>>   - Pass -lz to libdata/pkgconfig/cfitsio.pc
>>>   - Bump PORTREVISION for package change
>>>
>>>   PR:         ports/189487
>>>   Submitted by:       rakuco
>>
>> Can you patch cfitsio.pc to move @LIBS@ to the Libs.private field?
>> Other ports run 'pkg-config --libs cfitsio' to know what libraries
>> to link to and the output of that includes -lz now.
>> "-L${LIBDIR}" can be removed I think.  All compilers should search
>> it by default.
> 
> I prepared a new patch [1] which reverted r353466 and patched cfitsio.pc.
> It's OK in my tinderbox.
> Would you please check if it works for you?
> Thanks!
> 
> [1] https://people.freebsd.org/~sunpoet/cfitsio.patch

I think this may reintroduce the problem that Raphael reported.  The
problem is a line in Makefile.in that says "LDFLAGS=$(CFLAGS)".
If you add this to post-patch it'll be ok I think:

@${REINPLACE_CMD} -e '/^LDFLAGS =/ s|$$| @LDFLAGS@|' ${WRKSRC}/Makefile.in

To fix the PR the output of "ldd libcfitsio.so" must contain libz.