From owner-freebsd-testing@FreeBSD.ORG Sun Jan 26 08:21:50 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 12C9C6B1 for ; Sun, 26 Jan 2014 08:21:50 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D82371395 for ; Sun, 26 Jan 2014 08:21:49 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id q10so4653160pdj.38 for ; Sun, 26 Jan 2014 00:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LszM68+gxguSEFkoLPK9+aKGrPOroaI6z9aqWxUkIwg=; b=xU6Nln+/AIaDjaUHhpQ22G4PcKU0Ze9EjDsGL3B/j6fDBLfN1XVWkmNxs3fLGgcZMO H5LrpoSAuK4YYN3cNlltjRBbLCJWzhfninJlF33ebsTo1Z3mDBuBOWcoubB0+/PZvSor IH02gYfqPcoLS006hXs22NlcwL+Jp8j64Pu1ortgdw1FyYlGzhbiw95bxyoSOcEqRsCA yh+gc+c3FhJGInawT+n12/2HpJVjOizfrnOKc29C+TuNGWJ1wdgDfquVuLaduBlJKiLI nqQWNNdKYwzRcOexQTQEP+X1njrRBJX9+CsrlzzW9RIfhVZJLgcpu8rLkZql2XNUzPtl BfeQ== X-Received: by 10.66.149.7 with SMTP id tw7mr23932305pab.72.1390724509557; Sun, 26 Jan 2014 00:21:49 -0800 (PST) Received: from [192.168.20.5] (c-50-181-163-89.hsd1.wa.comcast.net. [50.181.163.89]) by mx.google.com with ESMTPSA id vx10sm53683128pac.17.2014.01.26.00.21.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 26 Jan 2014 00:21:49 -0800 (PST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: [PATCH] convert /bin/sh tests over to ATF From: Garrett Cooper In-Reply-To: Date: Sun, 26 Jan 2014 00:21:47 -0800 Content-Transfer-Encoding: 7bit Message-Id: <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> References: <20140124162759.GB90996@stack.nl> To: Julio Merino X-Mailer: Apple Mail (2.1827) Cc: freebsd-testing@freebsd.org, Jilles Tjoelker X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 08:21:50 -0000 On Jan 24, 2014, at 3:33 PM, Julio Merino wrote: > On Fri, Jan 24, 2014 at 11:27 AM, Jilles Tjoelker wrote: >> >> There may be some point in marking tests that are supposed to work on >> any POSIX-compliant sh and ones that are inherently FreeBSD-specific, or >> possibly more granular. However, this would be most useful when someone >> who cares about another sh implementation works on it. > > That's a worthy goal, but only if the test suite was an "external > component" that you shipped outside of FreeBSD and was easily > applicable to other systems. > > As it is now, the test suite lives in the FreeBSD tree and therefore > it can be considered to be FreeBSD-specific. Special-casing things out > as only applying to FreeBSD will be difficult to maintain and make > little sense in the current context. > > Now... all this can (and should) easily turn into the more generic > discussion of: how to define tests that can be shared across the > various BSDs and how to better maintain them? I currently have no > answer for that, but it's a pretty large topic to cover. Indeed.. -Garrett