From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 11 23:50:23 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4E6316A4CE for ; Mon, 11 Apr 2005 23:50:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C0BF43D3F for ; Mon, 11 Apr 2005 23:50:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3BNoNNW088188 for ; Mon, 11 Apr 2005 23:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3BNoNkG088187; Mon, 11 Apr 2005 23:50:23 GMT (envelope-from gnats) Resent-Date: Mon, 11 Apr 2005 23:50:23 GMT Resent-Message-Id: <200504112350.j3BNoNkG088187@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Wojciech A. Koszek" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D91316A4CE for ; Mon, 11 Apr 2005 23:41:44 +0000 (GMT) Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46FBA43D2D for ; Mon, 11 Apr 2005 23:41:41 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j3BNoIKf030504 for ; Mon, 11 Apr 2005 23:50:18 GMT (envelope-from dunstan@freebsd.czest.pl) Received: (from dunstan@localhost) by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j3BNoIQv030503; Mon, 11 Apr 2005 23:50:18 GMT (envelope-from dunstan) Message-Id: <200504112350.j3BNoIQv030503@freebsd.czest.pl> Date: Mon, 11 Apr 2005 23:50:18 GMT From: "Wojciech A. Koszek" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/79806: [PATCH] ng_cisco(4) allocates too much memory. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Wojciech A. Koszek" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2005 23:50:23 -0000 >Number: 79806 >Category: kern >Synopsis: [PATCH] ng_cisco(4) allocates too much memory. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 11 23:50:23 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Wojciech A. Koszek >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #7: Tue Apr 12 00:11:29 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386 >Description: ng_cisco(8) allocates too much memory for message. Macro NG_MKRESPONSE(rsp, msg, len, how) allocates memory for "struct ng_mesg" itself. "len" is number of bytes in rsp->data. >How-To-Repeat: cvs -d anoncvs@anoncvs.freebsd.org:/home/ncvs co -p src/sys/netgraph/ng_cisco.c | head -267 | tail -10 >Fix: Simple patch [diff.0.ng_cisco.c] which corrects this. Index: src/sys/netgraph/ng_cisco.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_cisco.c,v retrieving revision 1.27 diff -r1.27 ng_cisco.c 264,265c264 < NG_MKRESPONSE(resp, msg, sizeof(struct ng_mesg) < + NG_TEXTRESPONSE, M_NOWAIT); --- > NG_MKRESPONSE(resp, msg, NG_TEXTRESPONSE, M_NOWAIT); >Release-Note: >Audit-Trail: >Unformatted: