From owner-freebsd-current@FreeBSD.ORG Mon Feb 16 05:39:36 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 569E016A4CE for ; Mon, 16 Feb 2004 05:39:36 -0800 (PST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.184]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED47043D31 for ; Mon, 16 Feb 2004 05:39:35 -0800 (PST) (envelope-from max@love2party.net) Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1AsiyE-0008K2-00 for current@freebsd.org; Mon, 16 Feb 2004 14:39:34 +0100 Received: from [217.227.154.196] (helo=vampire.homelinux.org) by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 1AsiyE-0007La-00 for current@freebsd.org; Mon, 16 Feb 2004 14:39:34 +0100 Received: (qmail 39951 invoked from network); 16 Feb 2004 13:43:49 -0000 Received: from unknown (HELO fbsd52.laiers.local) (192.168.4.88) by 192.168.4.1 with SMTP; 16 Feb 2004 13:43:49 -0000 From: Max Laier To: Jiri Mikulas Date: Mon, 16 Feb 2004 14:39:27 +0100 User-Agent: KMail/1.5.4 References: <200402161119.01876.max@love2party.net> <4030B0C6.9040809@mikulas.com> In-Reply-To: <4030B0C6.9040809@mikulas.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_PgMMAWgduU7bZG1" Message-Id: <200402161439.27830.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 cc: bms@freebsd.org cc: Robert Watson cc: current@freebsd.org Subject: Re: PANIC: trap.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2004 13:39:36 -0000 --Boundary-00=_PgMMAWgduU7bZG1 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Monday 16 February 2004 13:00, Jiri Mikulas wrote: > Hello > > >Can you also provide 'args' and '*dummytag' from the same frame? > > > >Thanks in advance. > > ~~~cut~~~ > #6 0xc05726c8 in ip_output (m=0xc10f7200, opt=0x0, ro=0xc2abab68, > flags=1, imo=0x0, inp=0x0) at /usr/src/sys/netinet/ip_output.c:983 > 983 if (sw_csum & CSUM_DELAY_DATA) { > (kgdb) inspect args > $1 = {m = 0xc10f7200, oif = 0x0, next_hop = 0x0, rule = 0xc2943800, eh > = 0x0, ro = 0x1, dst = 0xc2abab40, flags = -1055947264, f_id = { dst_ip > = 169558539, src_ip = 169542160, dst_port = 64147, src_port = 80, proto > = 6 '\006', flags = 18 '\022'}, retval = 48} > (kgdb) inspect *dummytag > $2 = {m_tag_link = {sle_next = 0x0}, m_tag_id = 15, m_tag_len = 48, > m_tag_cookie = 0, m_tag_free = 0xc0522614 <_m_tag_free>} > (kgdb) > ~~~cut~~~ > > ok?:) > Jiri Well, we hit the dummynet case for sure and should get the proper interface pointer from the packet tag. Nothing changed with the processing there. The only change I found is, that the presents of a dummynet tag in ip_output previously reset flags, which is no longer that case. Can you try attached patch to see if that is the issue (from reading the code I don't really hope that this will be it, but it's the only thing I can come up with atm, sorry.) -- Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-00=_PgMMAWgduU7bZG1 Content-Type: text/x-diff; charset="iso-8859-1"; name="ip_output.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ip_output.c.diff" Index: ip_output.c =================================================================== RCS file: /cvsdrop/mlaier/fcvs/src/sys/netinet/ip_output.c,v retrieving revision 1.207 diff -u -r1.207 ip_output.c --- ip_output.c 13 Feb 2004 19:14:15 -0000 1.207 +++ ip_output.c 16 Feb 2004 12:59:58 -0000 @@ -195,9 +195,12 @@ m_tag_unlink(m, dummytag); args.rule = dt->rule; + opt = NULL; ro = &dt->ro; + imo = NULL; dst = dt->dn_dst; ifp = dt->ifp; + flags = dt->flags; ip = mtod(m, struct ip *); hlen = ip->ip_hl << 2 ; --Boundary-00=_PgMMAWgduU7bZG1--