From owner-freebsd-ports Tue Feb 6 8:17:44 2001 Delivered-To: freebsd-ports@freebsd.org Received: from ringworld.nanolink.com (pool114-tch-2.Sofia.0rbitel.net [212.95.171.114]) by hub.freebsd.org (Postfix) with SMTP id C8E7437B4EC for ; Tue, 6 Feb 2001 08:17:25 -0800 (PST) Received: (qmail 712 invoked by uid 1000); 6 Feb 2001 16:15:36 -0000 Date: Tue, 6 Feb 2001 18:15:36 +0200 From: Peter Pentchev To: Maxim Sobolev Cc: Jordan Hubbard , ports@FreeBSD.org, jkh@FreeBSD.org, Edwin Groothuis Subject: Re: Request for comments [Fwd: bin/24695: [patch] pkg_info: prefix search for a package] Message-ID: <20010206181536.B406@ringworld.oblivion.bg> Mail-Followup-To: Maxim Sobolev , Jordan Hubbard , ports@FreeBSD.org, jkh@FreeBSD.org, Edwin Groothuis References: <10197.981450491@winston.osd.bsdi.com> <3A7FC36A.1434D2CC@FreeBSD.org> <3A801D32.DE73F780@FreeBSD.org> <20010206180825.A406@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010206180825.A406@ringworld.oblivion.bg>; from roam@orbitel.bg on Tue, Feb 06, 2001 at 06:08:25PM +0200 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Feb 06, 2001 at 06:08:25PM +0200, Peter Pentchev wrote: > > The patches look great! I'll test them in an hour or two.. > Just a minor comment: in the rexs_match() function, you compile > each pattern time and again, for each package. Not that it would > matter a lot (the actual performance bottleneck would be disk I/O, > I suppose), but it could fasten things a bit if you precompiled ^^^^^^ 'speed up' would surely be better here :P Time to get some sleep ;) > all patterns into a regex_t array at the start. G'luck, Peter -- Do you think anybody has ever had *precisely this thought* before? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message