From owner-dev-commits-ports-all@freebsd.org Mon Sep 27 14:25:59 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACC5D6B6CFE; Mon, 27 Sep 2021 14:25:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HJ4gW4Q7Gz3MY1; Mon, 27 Sep 2021 14:25:59 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1632752759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERrzC6QaUG4xa2jqPCRc0h1gzYt4+GLXFsnaiziqqII=; b=LAkvRyYN5y/IVvsws24fMEqAwN8rTXXB+3F+evIDec0HBecwnhiYzVWdtPltm33TzMxxg5 3vcasuL2az9yrqejH/RBqSSr1IhP1TIwCazZH9KNz8zckEchYQx1+OTHnPirAzEGbY68OQ dYGLGVLgM9KF8lClaj9uxqCUA2JseeeB+NiZu4IFTwzFGj5cST6jj33ARrumwU2iJAqHiD 46//68aFunNRMUm77neWvcCbeA4VY/6gUUnILWUk86hRJxFiaBQA0y14sIMkErDl8qFnIt x6O/h8zisuX1NnuxWJ/h3R3kYBW0MF1eVrdZgmwEgbxbcfW53TZ2FhcD4rqwZg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 844326559; Mon, 27 Sep 2021 14:25:59 +0000 (UTC) Date: Mon, 27 Sep 2021 14:25:59 +0000 From: Alexey Dokuchaev To: Guido Falsi Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 895bc805a975 - main - www/webkit2-gtk3: update to 2.34.0 Message-ID: References: <202109270840.18R8e9bN044971@gitrepo.freebsd.org> <20210927100250.3f6injyvuw6lbufp@aniel.nours.eu> <8af11968-8b08-3e5c-e0de-56f1f63f57b0@FreeBSD.org> <63723cf0-1dea-f4c6-6d48-d91cbb4e7ebb@FreeBSD.org> <7efc5dc6-483e-e2e9-b84d-eb37979527f8@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7efc5dc6-483e-e2e9-b84d-eb37979527f8@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1632752759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERrzC6QaUG4xa2jqPCRc0h1gzYt4+GLXFsnaiziqqII=; b=GGMjWSV0KISJL3TyFqEi7eIG1UJAr7WOi52E6/c4Yrb95DQrfrUt8gR/DjHbND3XEroere 4zPYuzFK4MSRvC/e01mNiFm/w8F7FB8LG8oj5fpLUsQvf9r2/ySFyGU692C0KN5fMerCoi 5eh9Wb0B6OTyPhmDZ8F04mehfS1FGHfe7YFb8cytMmk/zVNvxTY4y81S08XC6WIJWTV6Wl GpmyXv7Rr8RYltIzRbx4LoQ+TnoZBx+8oZTMrM9VzSjV3xUjWGwWI/5r28Rpq5sA9D81AY wUAl8zCFidFLnUV2uvPDjSQqhlcs+VdnPf+lZEyWkMwreBvpJEBxmYv72biynQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1632752759; a=rsa-sha256; cv=none; b=U8RPn6vYmV3K0l7rAWWhMzgjWpoq9SoXbU1kK8O7YnqQmbTnSKIC0DO4FUmCDC/m3REPLT j+M1TpQHzNDTnow7DOiyB3UHmC3+TEBftS3YhpsVZeGCSmgoGZfziMBVACTwIEIAWbRcQ8 JTAxPo/5qqC+1i9EiFx1Qag0QppVg5+TbzcP14pVsP9GXnOyMK9FJrPOrLsA5mJP5FCdW4 te4UqoWmw8nEBYDhJ/WY6RQzDGJCjzoQFnVi809BOR+qU2VyYUY5T9DB9VmzbT6dTAE9RW tGuf6DMZLlFPBELlkgv7If/biw5qKLdj5CTsxW/2Sd71nhwvd9rtATfscnp4ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 14:25:59 -0000 On Mon, Sep 27, 2021 at 04:10:14PM +0200, Guido Falsi wrote: > On 27/09/21 15:47, Alexey Dokuchaev wrote: > > On Mon, Sep 27, 2021 at 03:38:09PM +0200, Guido Falsi wrote: > >> ... > >> I noticed I have the GSTREAMER option disabled in that poudriere jail. > >> > >> Enabling GSTREAMER again makes it compile. > >> > >> So while this narrows things down the option should be removed or fixed. > > > > Please don't remove this very useful option, at most it could be marked as > > BROKEN unilt it's fixed. I'll look into it once I have some spare time. > > I suspect I was not perfectly clear. The option works when enabled, but > when disabled brakes the port. This was quite clear. I suspect it was me who wasn't clear: when I said "marked as BROKEN" I meant the option, not the port, but even what's not really called for. > So by "removing the option" i meant just that, remove the option and > make the functionality mandatory. And this is what I'm against. I always disable GStreamer in all the ports I can, so this option is important, hence please don't remove it and give those who's motivated enough some time to look into fixing it. It's not a big deal and most users won't notice as it's enabled by default, but removing and then reintroducing it would cause needless repochurn. ./danfe