Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Aug 2017 10:18:28 +0200
From:      Ed Schouten <ed@nuxi.nl>
To:        Conrad Meyer <cem@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r322942 - head/sys/kern
Message-ID:  <CABh_MKknHyosfENq8SPzSOAhGFKL_tALfNdn5=eJqa29yjFqSA@mail.gmail.com>
In-Reply-To: <201708270514.v7R5EmDK064785@repo.freebsd.org>
References:  <201708270514.v7R5EmDK064785@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Conrad,

[ Context: I don't understand anything about CPU topologies! ]

2017-08-27 7:14 GMT+02:00 Conrad Meyer <cem@freebsd.org>:
> +       while (top->cg_children == 1) {
> +               top = &top->cg_child[0];
> +               top->cg_parent = NULL;
> +       }

This only removes layers from the top if they only have a single
child. Question: is it possible/likely to have CPU topologies where
one of the middle layers only has one child? If so, would it make
sense to use tree traversal here to do the flattening?

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKknHyosfENq8SPzSOAhGFKL_tALfNdn5=eJqa29yjFqSA>