From owner-freebsd-current@FreeBSD.ORG Tue May 17 17:11:17 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD6C016A4D0; Tue, 17 May 2005 17:11:17 +0000 (GMT) Received: from mvs3.plala.or.jp (c158131.vh.plala.or.jp [210.150.158.131]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4111643DC9; Tue, 17 May 2005 17:11:16 +0000 (GMT) (envelope-from bland@FreeBSD.org) Received: from hub.bbnest.net ([60.34.9.82]) by mvs3.plala.or.jp with ESMTP id <20050517171111.KTTO17326.mvs3.plala.or.jp@hub.bbnest.net>; Wed, 18 May 2005 02:11:11 +0900 Received: from [10.0.0.2] (bland@nest.bbnest.net [10.0.0.2]) by hub.bbnest.net (8.13.3/8.13.1) with ESMTP id j4HHBAdc065512; Wed, 18 May 2005 02:11:10 +0900 (JST) (envelope-from bland@FreeBSD.org) Message-ID: <428A25A2.4020206@FreeBSD.org> Date: Wed, 18 May 2005 02:10:58 +0900 From: Alexander Nedotsukov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050513 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alexander Nedotsukov References: <428A1AE0.1020407@FreeBSD.org> In-Reply-To: <428A1AE0.1020407@FreeBSD.org> Content-Type: multipart/mixed; boundary="------------030108020302080306090305" cc: current@FreeBSD.org cc: des@FreeBSD.org Subject: Re: nfsclient broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2005 17:11:17 -0000 This is a multi-part message in MIME format. --------------030108020302080306090305 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Here is what I think was actually implied. Alexander Nedotsukov wrote: > Hi, FYI; Just complete full 6-CURRENT update. Now all nfs mounts (used > to be rw) stays read-only. > > /sys/nfsclient/nfs_vfsops.c: > $FreeBSD: src/sys/nfsclient/nfs_vfsops.c,v 1.175 2005/05/17 > 12:00:43 des Exp $ > > BTW. Commit log do not match actual change. > > Alexander. > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" --------------030108020302080306090305 Content-Type: text/x-patch; name="nfs_vfsops.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="nfs_vfsops.c.diff" Index: nfs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/nfsclient/nfs_vfsops.c,v retrieving revision 1.175 diff -u -r1.175 nfs_vfsops.c --- nfs_vfsops.c 17 May 2005 12:00:43 -0000 1.175 +++ nfs_vfsops.c 17 May 2005 16:53:30 -0000 @@ -519,9 +519,9 @@ * flag is already clear, or this is a root mount and it was set * intentionally at some previous point. */ - if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL) != 0) + if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL) == 0) mp->mnt_flag |= MNT_RDONLY; - else if (!(mp->mnt_flag & MNT_UPDATE)) + else if (mp->mnt_flag & MNT_UPDATE) mp->mnt_flag &= ~MNT_RDONLY; /* --------------030108020302080306090305--