Date: Sat, 15 Mar 2008 09:23:10 +0100 From: lulf@stud.ntnu.no To: rick-freebsd@kiwi-computer.com Cc: freebsd-geom@freebsd.org Subject: Re: [patch] geom_vinum platform fixes Message-ID: <20080315092310.g35m2dzkgcko4k8o@webmail.ntnu.no> In-Reply-To: <20080313182257.GB14969@keira.kiwi-computer.com> References: <20080310052711.GA49676@keira.kiwi-computer.com> <20080313153551.82wlu8iio4088c44@webmail.ntnu.no> <20080313182257.GB14969@keira.kiwi-computer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Siterer "Rick C. Petty" <rick-freebsd@kiwi-computer.com>: > On Thu, Mar 13, 2008 at 03:35:51PM +0100, lulf@stud.ntnu.no wrote: >> >> I've spent a _lot_ of time fixing gvinum, so your previous statements >> saying noone is fixing gvinum really is wrong :) > SNIP >> I'm sorry this is taking so >> long, but there has been much time invested in 7.0 before gvinum. I'm >> also in Japan for another two weeks, so I won't be able to continue a >> discussion on this right now. >> >> But I agree with your changes, and I'll review and integrate your change= s >> to the new code base ASAP, but this will probably not go in until the >> new gvinum >> codebase iscommitted, since that will probably happen before 7.1/6.4 any= way > > I'm not sure I want to wait that long. My changes should not conflict wit= h > yours (and if they do, the overlap would be minimal). I don't see why the > world should wait until 7.1 to see this fixed. Right now, people cannot > migrate vinum partitions between i386 and amd64. These people don't need > all your improvements for that. Besides, my small patch introduces little > to no instability to geom_vinum and fixes a key piece of broken code. > Compared to your larger commit, I would think people would prefer to see m= y > patch committed immediately and your work to be integrated when you have > time to test and commit it. > Hmm, yes. I didnt look very detailed at the patch so I was not sure if =20 it would conflict or not. > That being said and since there have been no objections to my suggestions > (and Ulf agrees with my changes), is a committer willing to review my > patch? le@ ? Mr. Lehey? > or lulf@ :) I can commit it after Ive reviewed it unless someone else volunteers =20 before Icome back from Japan (The 25th of march). > -- Rick C. Petty > > --=20 Ulf Lilleengen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080315092310.g35m2dzkgcko4k8o>