From nobody Sun Feb 12 22:29:01 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMZr1g3dz3pHBd for ; Sun, 12 Feb 2023 22:29:08 +0000 (UTC) (envelope-from fbl@aoek.com) Received: from mail.yourbox.net (mail.yourbox.net [IPv6:2001:41d0:1:767d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.yourbox.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMZr0Jmqz4ZKp; Sun, 12 Feb 2023 22:29:07 +0000 (UTC) (envelope-from fbl@aoek.com) Authentication-Results: mx1.freebsd.org; none Received: from mail.yourbox.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail.yourbox.net (8.17.1/8.17.1) with ESMTP id 31CMT6xg052923; Sun, 12 Feb 2023 23:29:06 +0100 (CET) (envelope-from fbl@aoek.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aoek.com; s=mailbox; t=1676240946; bh=XXk7H8kOVouQ9924YJ3YLZgeU1ys7/rndOw6KmEJoNo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YLfmslHDpyGQPutT8iyjHQQ7+/NgnXZrUIc825V9I7ma7wqx8DU8IpVVLiibmZq24 HtmCrDGHSkmOq33+jAJPFLWKSIz+t02H50ikeytbtOVBtaVxZ6dVt6bv01g1+PenzV UihAFncQOIDsrWFX/jCKVYAbPVdsxf4XyKBQyEKSEEYSsxW6aH37/+t6M95qdDGStn NIvdNys9Ng5AfHX9dCrd346FIwzjVE9/yAqpFhIY6yYuYmxvlDCS2V1yM0Xcr2U1Dx jmJm3d0xY8xY6aOk4rYha8FmSUCnAi3q9TtSOzS+QVr4tr9Otqy03Gmbihk7IXztrs xUAzMcH6Ydn9g== List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sun, 12 Feb 2023 23:29:01 +0100 From: =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= To: Dimitry Andric Cc: Guido Falsi , andrew clarke , FreeBSD Ports Subject: Re: editors/uemacs fails to biuld on 14.0-CURRENT 1400079 In-Reply-To: <8EA8CA09-BBD4-455A-8946-57A2755690B3@FreeBSD.org> References: <8aceaed7bb0323fc53143a8befd35170@mail.yourbox.net> <20230211111245.o3qjm3oyncivtipu@ozzmosis.com> <8EA8CA09-BBD4-455A-8946-57A2755690B3@FreeBSD.org> Message-ID: <4826f5f6531cd30c42c0882cbda55fce@mail.yourbox.net> X-Sender: fbl@aoek.com User-Agent: Roundcube Webmail/1.2.0 X-Rspamd-Queue-Id: 4PFMZr0Jmqz4ZKp X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N El 2023-02-12 11:09, Dimitry Andric escribió: ... > tl;dr: > > * old software breaking with -Wimplicit-function-declaration and > -Wimplicit-int errors can be fixed by setting USE_CSTD=gnu89 (or > whatever is necessary to make it use -std=gnu89). > * software breaking with -Wint-conversion should ideally have their > integer-to-pointer or pointer-to-integer conversions fixed, but > otherwise the error can be silened with -Wno-int-conversion. Dimitry, thank you for the detailed insight. I am using your suggestions to fix other ports as well. I could not manage to have USE_CSTD work, not for uemacs nor for other ports, so this patch works for me. diff --git a/editors/uemacs/Makefile b/editors/uemacs/Makefile index f999cc978685..48111ffb8824 100644 --- a/editors/uemacs/Makefile +++ b/editors/uemacs/Makefile @@ -19,6 +19,8 @@ NO_WRKSUBDIR= yes USES= dos2unix ncurses zip EXTRACT_BEFORE_ARGS= -Lq +CFLAGS+= -Wno-int-conversion + post-patch: @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ BR, -- José Pérez